Test against ETS packages from source using travis cron jobs.#795
Merged
Conversation
added 6 commits
June 28, 2019 16:02
specifically, install the ETS packages from source instead of installing the released versions of the packages modified: .travis.yml new file: ci/ci-src-requirements.txt
this is to test the outcome of the cron job instead of waiting for the cron job modified: .travis.yml
modified: ci/ci-src-requirements.txt
i.e. dont install packages from source unless the travis event type is cron modified: .travis.yml
This is very very old and currently, the travis config file has a before_install section which is used to setup the travis env deleted: .travis_before_install
This should have been removed when the travis config file was updated to uze xenial instead of trusty. modified: .travis.yml
Contributor
Author
|
Travis CI for the commit ddf9a59 does what we expect - it installs the ETS packages from source and runs the tests. |
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
==========================================
- Coverage 50.94% 50.86% -0.09%
==========================================
Files 263 263
Lines 23845 23845
Branches 3252 3252
==========================================
- Hits 12149 12129 -20
- Misses 10910 10929 +19
- Partials 786 787 +1
Continue to review full report at Codecov.
|
prabhuramachandran
approved these changes
Jun 30, 2019
Member
prabhuramachandran
left a comment
prabhuramachandran
left a comment
There was a problem hiding this comment.
LGTM! Many thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install ETS packages from source when the travis event type is a cron job.