FIX: Fix set_range#735
Merged
Merged
Conversation
Collaborator
Author
|
Pushed a test that fails if the changes from |
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
+ Coverage 51.77% 51.81% +0.04%
==========================================
Files 259 259
Lines 23424 23429 +5
Branches 3200 3202 +2
==========================================
+ Hits 12127 12139 +12
+ Misses 10509 10502 -7
Partials 788 788
Continue to review full report at Codecov.
|
Member
prabhuramachandran
left a comment
prabhuramachandran
left a comment
There was a problem hiding this comment.
Thanks, just a few minor questions that would be nice to have answered before this is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my scripts I kept seeing things like:
Turns out it's because internally the code somewhere does essentially:
The problem is that the first set causes a trait notification, and can lead to the condition in
_vmin_changedthatself.vmin is not Nonebutself.vmax is None; and if the max of the data is less thanself.vminyou end up inlut_managertrying to set things incorrectly.This puts some sort of fix in both places just to be safe.