Skip to content

ENH: Feature to disable automatic updates.#712

Merged
prabhuramachandran merged 1 commit into
enthought:masterfrom
prabhuramachandran:disable-update
Sep 8, 2018
Merged

ENH: Feature to disable automatic updates.#712
prabhuramachandran merged 1 commit into
enthought:masterfrom
prabhuramachandran:disable-update

Conversation

@prabhuramachandran
Copy link
Copy Markdown
Member

This can be very handy at times when the automatic updates can trigger
several changes that are not desirable. For example on certain VTK
calls, internal ModifiedEvents may be fired which will automatically
call the update_traits method which can be wired to other events
triggering problems. In these cases one can use the
global_disable_update function to temporarily disable updates.

Also fix some PEP8 errors and a few places where the state of the object
could be incorrectly set due to exceptions being raised.

This can be very handy at times when the automatic updates can trigger
several changes that are not desirable.  For example on certain VTK
calls, internal ModifiedEvents may be fired which will automatically
call the update_traits method which can be wired to other events
triggering problems.  In these cases one can use the
`global_disable_update` function to temporarily disable updates.

Also fix some PEP8 errors and a few places where the state of the object
could be incorrectly set due to exceptions beinf raised.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 8, 2018

Codecov Report

Merging #712 into master will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
+ Coverage   51.33%   51.34%   +0.01%     
==========================================
  Files         259      259              
  Lines       23648    23657       +9     
  Branches     3226     3227       +1     
==========================================
+ Hits        12139    12147       +8     
+ Misses      10722    10721       -1     
- Partials      787      789       +2
Impacted Files Coverage Δ
tvtk/api.py 100% <100%> (ø) ⬆️
tvtk/tvtk_base.py 79.05% <82.6%> (+0.29%) ⬆️
tvtk/wrapper_gen.py 10.96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a94288...6e4d242. Read the comment docs.

@prabhuramachandran prabhuramachandran merged commit 9eff3b1 into enthought:master Sep 8, 2018
@prabhuramachandran prabhuramachandran deleted the disable-update branch September 8, 2018 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants