Fix wrapping VTK's Get* methods#693
Merged
prabhuramachandran merged 5 commits intoAug 1, 2018
Merged
Conversation
This generally works better with the new pipeline.
These versions have a float16/float128 dtype which are not directly supported in VTK.
Many of the new pipeline methods were not wrapped correctly. For example the vtkAlgorithm.GetInputAlgorithm has multiple signatures. TVTK was wrapping any getter which had one of its signatures with no args as a pure property and not exposing the method itself. This means that users cannot call `obj.get_input_algorithm(0, 0)` which is broken. We now wrap the no arg call as a property but also wrap the generic method as a callable method.
Add a few reasonable tests for the browser.
prabhuramachandran
changed the title
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 50.59% 50.95% +0.35%
==========================================
Files 257 257
Lines 23443 23436 -7
Branches 3198 3195 -3
==========================================
+ Hits 11862 11942 +80
+ Misses 10822 10717 -105
- Partials 759 777 +18
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getmethods correctly. Many of the new pipeline methods were not wrapped correctly. For example thevtkAlgorithm.GetInputAlgorithmhas multiple signatures. TVTK was wrapping any getter which had one of its signatures with no args as a pure property and not exposing the method itself. This means that users cannot callobj.get_input_algorithm(0, 0)which is broken. We now wrap the no arg call as a property but also wrap the generic method as a callable method.