Make array_ext optional.#661
Merged
prabhuramachandran merged 1 commit intoJun 28, 2018
Merged
Conversation
On a Python environment where compilation is not possible, this extension prevents installation via pip. We now have a slower alternative for such environments which allow us to continue to install Mayavi without building the extension. The extension is only added conditionally, so those who can build the package correctly will get the added performance. This addresses enthought#658 and should make Mayavi even easier to install for the average user.
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
==========================================
- Coverage 50.45% 50.45% -0.01%
==========================================
Files 257 257
Lines 23328 23359 +31
Branches 3181 3184 +3
==========================================
+ Hits 11771 11785 +14
- Misses 10802 10818 +16
- Partials 755 756 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Python environment where compilation is not possible, this
extension prevents installation via pip. We now have a slower
alternative for such environments which allow us to continue to install
Mayavi without building the extension. The extension is only added
conditionally, so those who can build the package correctly will get the
added performance. This addresses #658 and should make Mayavi even
easier to install for the average user.