Codecov Report

Merging #641 into master will increase coverage by 0.04%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   50.41%   50.46%   +0.04%     
==========================================
  Files         257      257              
  Lines       23415    23327      -88     
  Branches     3194     3180      -14     
==========================================
- Hits        11804    11771      -33     
+ Misses      10850    10801      -49     
+ Partials      761      755       -6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfacd49...b90054b. Read the comment docs.

On a quick look-over, I think you should explicitly attempt to import pyface.toolkit module in the tvtk.pyface.*.init modules to ensure that appropriate initialization of the UI occurs (see, eg. https://github.com/enthought/traitsui/blob/master/traitsui/wx/toolkit.py#L32 and https://github.com/enthought/traitsui/blob/master/traitsui/qt4/toolkit.py#L24). In particular, this ensures that the equivalent of the code that was deleted that initializes the _app instance gets run somewhere.

It is suboptimal that importing pyface.toolkit has important side-effects, but we are stuck with that behaviour, I think (in particular, you can't make some Qt calls until the app exists).

I'll have a closer look tomorrow morning.

Hmm, it seems to work fine as is, the tests pass. Since Mayavi is using traitsui shouldn't it be enough that traitsui will perform the necessary imports?

@corranwebster -- please let me know if this looks OK. Thanks!

It's probably fine, assuming that you can't use Mayavi without bringing in TraitsUI at some point in the process.

Thank you! Yes indeed when we do use a UI, we use traitsui. When we don't want a UI we don't want the Qt or wx app to be created anyway. So I think it should be fine.