Qt5 support#528
Merged
prabhuramachandran merged 6 commits intoJul 19, 2017
Merged
Conversation
Member
prabhuramachandran
commented
Jul 16, 2017
prabhuramachandran
commented
- Basic support for Qt5. This makes Mayavi compatible with PyQt5.
- This requires the latest traits, traitsui, and pyface from master. A new release may be forthcoming for these packages soon.
- This works well with VTK-8.x which is typically not available on most Python packages but is easy to do by hand. On older versions, on MacOS, the embedded VTK window is half the size.
- There are some warnings about "Attempt to set a screen on a child window." which seem related to the toolbar used on the decorated scene. This seems like a pyface issue with the toolbar.
- Mlab and traits based dialogs work fine.
- Mayavi2 works but reparenting windows seems to not work very well suggesting that there are more migration issues in the other libraries.
- This PR also sneaks in a couple of Python3 migration bugs in Mayavi.
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 50.4% 50.38% -0.02%
==========================================
Files 255 255
Lines 22549 22580 +31
Branches 3005 3015 +10
==========================================
+ Hits 11365 11377 +12
- Misses 10454 10469 +15
- Partials 730 734 +4
Continue to review full report at Codecov.
|
|
bump Great work Can we get a release soon to try and integrate this new version in conda-forge? |
Member
Author
|
Perhaps next week, I am waiting for a traitsui and pyface release. Not sure about conda-forge but I will push it to pypi and then mayavi will be completely pip installable with the VTK wheels I just pushed a few weeks ago. |
|
brilliant |
|
Linking this to QPainter::begin: Paint device returned engine == 0, type: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.