Fix pick_world bug with VTK >= 6#508
Merged
Merged
Conversation
The pick_world function is still using the old VTK pipeline functions, added a check to that effect.
prabhuramachandran
requested changes
May 11, 2017
| from tvtk.common import configure_input | ||
| from apptools.persistence import state_pickler | ||
|
|
||
| VTK_MAJOR_VERSION = tvtk.Version().vtk_major_version |
Member
There was a problem hiding this comment.
You can just use from tvtk.common import vtk_major_version to get this instead of doing this again.
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
- Coverage 48.92% 48.91% -0.01%
==========================================
Files 255 255
Lines 23234 23238 +4
Branches 3064 3065 +1
==========================================
+ Hits 11367 11368 +1
- Misses 11138 11141 +3
Partials 729 729
Continue to review full report at Codecov.
|
Contributor
Author
|
@prabhuramachandran OK, modified |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pick_world function is still using the old VTK pipeline functions, added a check to that effect.