Remove focus-stealing code#506
Merged
Merged
Conversation
The enterEvent and leaveEvent callbacks in QVTKRenderWindowInteractor lead to focus stealing, causing problems in applications that embed a Mayavi scene,
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
=========================================
- Coverage 50.31% 48.92% -1.4%
=========================================
Files 257 255 -2
Lines 23241 23235 -6
Branches 3071 3064 -7
=========================================
- Hits 11694 11368 -326
- Misses 10798 11138 +340
+ Partials 749 729 -20
Continue to review full report at Codecov.
|
Member
|
Sounds good to me. @prabhuramachandran? The test failure is unrelated. |
Member
|
Looks OK to me too. The tests are a mess now. I'll start going over the PRs late this week but am happy to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enterEvent and leaveEvent callbacks in QVTKRenderWindowInteractor lead to focus stealing, causing problems in applications that embed a Mayavi scene,