Fix for setuptools 28.0#444
Merged
Merged
Conversation
Fixes #443. With setuptools 28.0, subpackages are not added if found within an exclusion prefix. We have to manually indicate which packages are available in the tvtk setup.py
Current coverage is 50.85% (diff: 0.00%)@@ master #444 diff @@
==========================================
Files 257 257
Lines 23219 23224 +5
Methods 0 0
Messages 0 0
Branches 3070 3070
==========================================
+ Hits 11687 11810 +123
+ Misses 10783 10680 -103
+ Partials 749 734 -15
|
Member
|
@stefanoborini -- thank you! Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443.
With setuptools 28.0, subpackages are not added if found within an exclusion prefix.
We have to manually indicate which packages are available in the tvtk setup.py
The code is neutral for setuptools <28.0