[MRG] Added a volume_slice helper function in mlab.#435
Conversation
volume_slice plots an image plane sliced through volumetric data
Current coverage is 50.32% (diff: 41.17%)@@ master #435 diff @@
==========================================
Files 257 257
Lines 23219 23236 +17
Methods 0 0
Messages 0 0
Branches 3070 3071 +1
==========================================
+ Hits 11687 11694 +7
- Misses 10783 10793 +10
Partials 749 749
|
|
@emmanuelle -- thanks for this, it looks great overall. The classic theme is just the classic sphinx theme. I have version 1.3.5, looks like you have an older 1.2.x version. I'm a bit swamped today so I will take a closer look over the next couple of days. Would it be possible to add a tiny non-UI test along the lines of https://github.com/enthought/mayavi/blob/master/mayavi/tests/test_mlab_integration.py#L230 but put it under this class: https://github.com/enthought/mayavi/blob/master/mayavi/tests/test_mlab_integration.py#L303 It shouldn't take too long I hope, just a simple test exercising the pipeline and making sure it all works. For example it would be nice to check if setting the axis is honored. If there are issues doing this on account of the null engine, please let me know. Thanks!! |
|
@prabhuramachandran is it the kind of unit test that you were expecting? I'm not sure I understand completely what you were asking for, but I gave it a try :-). I managed to build the doc with a more recent version of sphinx. |
|
ping @prabhuramachandran :-) |
|
Could you add a ref to this function in the section Aside from that, LGTM. |
|
Good idea, thanks! I added a reference, tell me if it's OK. I also mentioned that when creating several visualizations from a single NumPy array, it's better to use the pipeline syntax than duplicating data sources with several mlab functions. Not sure it's needed, but I think it's not obvious for all users. Tell me what you think. |
|
@emmanuelle -- very sorry for the slow response, I had some deadlines and didn't notice this thread due to a faulty email filter. Anyway, this looks perfect! Thank you so much for all your attention to detail! Am merging this right away! Thanks again! |
volume_slice plots an image plane sliced through volumetric data.
This PR addresses #430. I chose
volume_sliceinstead ofimage_slicethat was proposed in #430, since I thought it was clearer (a slice through volumetric data), but I'm open to changing the name of course.In addition to the function itself, I tried to modify the documentation as well, but I'm not sure whether I did it well or not since I get an error when building the doc: