Notebook support#415
Conversation
There are two modes supported, one is to dump PNG images for the scene and the second (the default) is to use x3d output and x3dom.js to render the scene. This works very well. This also adds the x3dom.js file to Mayavi so users can view the data even when disconnected from the internet.
|
Thanks @prabhuramachandran! Works like a charm.
|
| yield count | ||
| count += 1 | ||
|
|
||
| counter = _counter() |
There was a problem hiding this comment.
from itertools import counter as _counter
counter = _counter()
does the same thing
There was a problem hiding this comment.
Good point, will use this instead, thanks.
|
On Mac, if I set backend to 'png' I get black images...but that's a separate issue #257 |
|
If the backend is not set correctly in the middle, the behaviour is also appropriate. 👍 |
|
One super minor comment on |
|
@kitchoi -- thanks for the review and comments, as regards changing the backend, the recommended way to do it is to call |
Current coverage is 45.99%@@ master #415 diff @@
==========================================
Files 255 256 +1
Lines 23213 23292 +79
Methods 0 0
Messages 0 0
Branches 3067 3074 +7
==========================================
+ Hits 10606 10714 +108
+ Misses 11886 11880 -6
+ Partials 721 698 -23
|
|
Thanks @prabhuramachandran! Merging. |
4 participants
Adds support for displaying Mayavi images or x3d scenes on the notebook. The x3d scenes allow one to fully interact with the scene in the notebook.