Movie support#411
Conversation
This adds a `tvtk.pyface.movie_maker` which facilitates recording a movie. Also adds the ability to animate the timesteps for timeseries data. The timesteps for similar datasets can be synced.
If one has a scene with the movie_maker.record set to True, a movie will be recorded when the animation is run.
Also cleanup the movie maker a bit so a user can set the directory and expect things to work reasonably. Fixed a few minor bugs in the process.
Also fix an issue when sync_timestep is chosen and update_files is fired.
Current coverage is 45.68%@@ master #411 diff @@
==========================================
Files 254 255 +1
Lines 23030 23213 +183
Methods 0 0
Messages 0 0
Branches 3039 3067 +28
==========================================
+ Hits 10543 10606 +63
- Misses 11795 11886 +91
- Partials 692 721 +29
|
| label='Delay'), | ||
| Item(name='loop'), | ||
| ), | ||
| enabled_when='len(object.file_list) > 1' |
There was a problem hiding this comment.
maybe visible_when is cleaner than enable_when so the UI group just does not show up when there is only one file?
There was a problem hiding this comment.
Yes, I agree, I will change this.
There was a problem hiding this comment.
Ahh, I remember why I did this. I thought that if you start with a single file and then add a new one, it will not show the UI elements with visible_when. It appears that I am wrong. I just tested and this does work so I will use visible_when.
|
@prabhuramachandran The feature is cool! I have a few minor comments above and one question about the I tested it locally and manually with an animation function that merely modify the camera. It does not seem to make a difference whether The rest looks good to me. |
|
@kitchoi -- thanks for the review! The |
|
@kitchoi -- can this be merged? |
I'm sorry I should have explained what I tested more clearly. In fact I tested exactly this scenario and I have not encountered a problem. The experience is the same for both |
|
Well, if two loops are being called you will end up with two calls to animation_start which will produce two different directories which should not happen when support_movie is False. The animation will still rotate the scene so the view should be the same but the animated function will not call animation_start/stop/step. I don't think the traits or pyface versions will matter. Am I missing something? |
|
Thanks @prabhuramachandran Now I understood what the 'support_movie' does. I guess it is because of the context of the PR that I was confused. For others using 'animate', it should be clear what 'support_movie' does. Please feel free to merge. Thanks. |
|
@kitchoi -- thanks! Will merge this then. |
3 participants
Adds support for recording movies and animating timesteps. Also added some documentation for this feature. For a timeseries, one can simply select the "play" checkbox and see an animation. For the timestep and
mlab.animateone can very easily generate animations also.