Debug info on code gen#405
Merged
Merged
Conversation
Current coverage is 45.39%@@ master #405 diff @@
==========================================
Files 254 254
Lines 22987 22999 +12
Methods 0 0
Messages 0 0
Branches 3033 3034 +1
==========================================
+ Hits 10439 10441 +2
- Misses 11832 11842 +10
Partials 716 716
|
| import logging | ||
|
|
||
| # use a null handler when used as a library | ||
| logging.getLogger('tvtk').addHandler(logging.NullHandler()) |
Member
There was a problem hiding this comment.
Could you please explain why this is needed?
Member
Author
There was a problem hiding this comment.
Adding a null handler is suggested for libraries that use the python logging framework so that there is always a handler (see https://docs.python.org/2/howto/logging.html#configuring-logging-for-a-library).
Member
There was a problem hiding this comment.
Thanks, do you think this link could be put in a comment above this? Or is this obvious?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic debug support for the code_gen script
Details:
-v, --verboseoption on the code_gen script