Removes array_ext.so/pyd on clean#358
Merged
prabhuramachandran merged 4 commits intoApr 27, 2016
Merged
Conversation
Removes the extension as from issue #336.
Current coverage is 45.41%@@ master #358 diff @@
==========================================
Files 254 254
Lines 22891 22891
Methods 0 0
Messages 0 0
Branches 3028 3028
==========================================
Hits 10395 10395
Misses 11762 11762
Partials 734 734 |
| class MyClean(clean.clean): | ||
| def run(self): | ||
| print("Cleaning extensions") | ||
| clear_array_ext() |
Member
There was a problem hiding this comment.
Just implement it all in here. Your docstring and print message should note that it is deleting extensions that were built in-place in addition to the normal compile products that are cleaned.
prabhuramachandran
deleted the
feature/336-remove-array-ext-on-clean-0426-1148
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the extension as from issue #336.