Skip to content

Fix savefig size and black image #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanoborini merged 36 commits into from
Apr 21, 2016
Merged

Fix savefig size and black image #331

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
7f5c884
call SetSize for the vtkRenderWindow when wx.scene.set_size is called
kitchoi Mar 15, 2016
b8694c1
add pillow to travis-requirement
kitchoi Mar 15, 2016
80f13f0
added test for mlab.savefig
kitchoi Mar 15, 2016
d7cdb87
use cleanUp to close all figure instead of using contextmanager
kitchoi Mar 17, 2016
ac061bc
only the test using Engine + off_screen_rendering fails on master but…
kitchoi Mar 17, 2016
ae1f11c
let's only test against the image size and forget about black spots w…
kitchoi Mar 17, 2016
842d052
set_size was doing the right thing, instead it was because the window…
kitchoi Mar 17, 2016
3a3761f
size should be strictly respected. int(target_size // mag) gives wron…
kitchoi Mar 17, 2016
4d85baf
mend
kitchoi Mar 17, 2016
c5e2fb3
Revert "mend"
kitchoi Mar 17, 2016
bd68dd6
improve comment and function's order
kitchoi Mar 17, 2016
b035169
fix lanaguage in the comment [ci skip]
kitchoi Mar 17, 2016
a09a1a3
figure should be passed mlab.quiver3d in the test cases
kitchoi Mar 24, 2016
19529f8
calling the resize functions for two IdleEvent causes size to be wron…
kitchoi Mar 24, 2016
2b218a8
modified docstring for savefig
Mar 29, 2016
af88c5a
remove OnPaint handler after the scene is closed
kitchoi Mar 29, 2016
c00b284
create a new render window for snapshot
Mar 31, 2016
0597d50
revert lifting the window for offscreen rendering in wx
Mar 31, 2016
44eac58
Merge branch 'fix-savefig-black-image' into fix-savefig-size
Mar 31, 2016
233d993
added test for magnification and check for black spot
Mar 31, 2016
324d67f
Merge branch 'master' into fix-savefig-size-black-image
kitchoi Mar 31, 2016
e3e0c8d
check stereo/off_screen_rendering for older version of VTK
kitchoi Mar 31, 2016
7ce1d5b
read_front_buffer = False
kitchoi Mar 31, 2016
af81647
finalize temporary render window
kitchoi Mar 31, 2016
194e89d
use interactor if not on Mac
kitchoi Mar 31, 2016
e83050f
force offscreen for the temporary renderwindow for better user experi…
kitchoi Mar 31, 2016
e6563e7
safer to use offscreen rendering only when directed
kitchoi Mar 31, 2016
30e6e2b
use interactor to hold the render window when offscreen is true and n…
kitchoi Mar 31, 2016
9b91e6d
clean code
kitchoi Mar 31, 2016
fc916f9
whenever render is called, disable_render should be honoured
kitchoi Mar 31, 2016
8996ce2
fix comment
kitchoi Mar 31, 2016
2976e90
changes to read_front_buffer is not needed now
kitchoi Apr 1, 2016
54b7562
Merge branch 'master' into fix-savefig-size-black-image
kitchoi Apr 1, 2016
de243bb
Merge branch 'master' into fix-savefig-size-black-image
kitchoi Apr 1, 2016
82ece3a
better ordering of tests
kitchoi Apr 1, 2016
f7c6e46
xrange to range
kitchoi Apr 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
safer to use offscreen rendering only when directed
  • Loading branch information
@kitchoi
kitchoi committed Mar 31, 2016
commit e6563e7b538e4d616d0b84f1b90b3a6e8163c498
6 changes: 3 additions & 3 deletions tvtk/pyface/tvtk_scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,10 +415,10 @@ def save(self, file_name, size=None, **kw_args):
orig_renwin.remove_renderer(renderer)

# new render window only used here for saving the image
# set the size to (1, 1) and off_screen_rendering
# to prevent this window from showing
# set the size to (1, 1) in case of off_screen_rendering
# this window would not be shown
temp_renwin = tvtk.RenderWindow(
size=(1, 1), off_screen_rendering=True)
size=(1, 1), off_screen_rendering=self.off_screen_rendering)

# older VTK may not support stereo rendering
if orig_renwin.stereo_render:
Expand Down