Fix for exception when modifying extents#330
Merged
Merged
Conversation
| extentz = 0.5 * (zmax - zmin) | ||
| # Now the actual bounds. | ||
| xmin, xmax, ymin, ymax, zmin, zmax = module.actor.actor.bounds | ||
| xmin, xmax, ymin, ymax, zmin, zmax = module.actor.bounds |
Member
There was a problem hiding this comment.
I think this will need to be conditional. For example one could do the following:
actor = getattr(module.actor, 'actor', module.actor)
and then use actor.bounds etc. The reason is that in some cases the module.actor may not be an image actor, so one should test that for the case when the object is not an Image actor that it continues to work.
| scalez = 1 | ||
|
|
||
| module.actor.actor.scale = (scalex, scaley, scalez) | ||
| module.actor.scale = (scalex, scaley, scalez) |
Contributor
There was a problem hiding this comment.
actor.scale = (scalex, scaley, scalez)?
Contributor
Author
|
@prabhuramachandran @kitchoi can I merge? |
Member
|
LGTM. Sorry for the delay, can you resolve the conflicts and I will merge it right away. |
Contributor
|
@stefanoborini I can take this over if you're busy with other stuff? |
Contributor
Author
|
@kitchoi No I'll do it |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37