Skip to content

Replacing links to code. and svn.enthought.com#313

Merged
prabhuramachandran merged 6 commits into
masterfrom
clean-up-code-ent-links
Mar 17, 2016
Merged

Replacing links to code. and svn.enthought.com#313
prabhuramachandran merged 6 commits into
masterfrom
clean-up-code-ent-links

Conversation

@kitchoi
Copy link
Copy Markdown
Contributor

@kitchoi kitchoi commented Mar 10, 2016

Hunt down links to the code.enthought.com and svn.enthought.com domain.

Some of which are in scripts' docstrings that are invisible on the actual documentation website.

And I don't know what to do with these:

./docs/source/mayavi/installation.rst:.. _ETS: http://code.enthought.com/
./docs/source/mayavi/overview.rst:.. _ETS: http://code.enthought.com/projects/tool-suite.php
./examples/mayavi/mlab/chemistry.py:    'http://code.enthought.com/projects/mayavi/data/h2o-elf.cube'
./docs/source/mayavi/auto/chemistry.py:   'http://code.enthought.com/projects/mayavi/data/h2o-elf.cube'

Also don't know what to do with these:

./docs/API.txt:   https://svn.enthought.com/enthought/wiki/EnthoughtVersionNumbers
./mayavi/scripts/mayavi2.py:Mayavi2 wiki page: http://svn.enthought.com/enthought/wiki/MayaVi

I can't guarantee that I have done all of them, but this is a step forward.

@jdmarch can you take a look please?

@corranwebster
Copy link
Copy Markdown

corranwebster commented Mar 10, 2016

The link ./docs/API.txt: https://svn.enthought.com/enthought/wiki/EnthoughtVersionNumbers should point to the github repo (possibly to the releases sub-page https://github.com/enthought/mayavi/releases).

The link ./mayavi/scripts/mayavi2.py:Mayavi2 wiki page: http://svn.enthought.com/enthought/wiki/MayaVi should point to the Mayavi documentation http://docs.enthought.com/mayavi/mayavi/

@kitchoi
Copy link
Copy Markdown
Contributor Author

kitchoi commented Mar 10, 2016

Thanks @corranwebster! just updated those links

@corranwebster
Copy link
Copy Markdown

corranwebster commented Mar 10, 2016

Having a look, I think that the other ones have to wait until we know what we are going to do with code.enthought.com. The datasets that are stored there could be moved into the github repo and the download links updated to grab the appropriate url; or we could add them to the documentation and download them from docs.enthought.com, but either way we have to keep the datasets at code.enthought.com for a while because people will still have old versions of Mayavi around for a while.

corranwebster
corranwebster reviewed Mar 10, 2016
View reviewed changes
Comment thread README-tvtk.txt Outdated
the "register" link at the top right on the above page to register. Or login
if you already have registered. Once you are registered you may file a bug by
creating a new ticket.
https://github.com/enthought/mayavi
Copy link
Copy Markdown

@corranwebster corranwebster Mar 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May as well link directly to https://github.com/enthought/mayavi/issues

@corranwebster
Copy link
Copy Markdown

corranwebster commented Mar 10, 2016

Other than the above notes, looks good to me.

@kitchoi
Copy link
Copy Markdown
Contributor Author

kitchoi commented Mar 10, 2016

Thanks @corranwebster! I have made the changes

@kitchoi kitchoi mentioned this pull request Mar 14, 2016
Closed
@prabhuramachandran
Copy link
Copy Markdown
Member

prabhuramachandran commented Mar 17, 2016

@kitchoi -- this is fantastic, thank you so much!

prabhuramachandran added a commit that referenced this pull request Mar 17, 2016
@prabhuramachandran
Merge pull request #313 from enthought/clean-up-code-ent-links
1927066 
Replacing links to code. and svn.enthought.com
@prabhuramachandran prabhuramachandran merged commit 1927066 into master Mar 17, 2016
@prabhuramachandran prabhuramachandran deleted the clean-up-code-ent-links branch March 17, 2016 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kitchoi @corranwebster @prabhuramachandran