BUG: Set vertices for glyph source.#1103
Merged
prabhuramachandran merged 3 commits intoNov 8, 2021
Merged
Conversation
We were abusing the polys earlier to set the scalar_scatter cell information but it seems safer and more correct to use the verts. This fixes enthought#1071.
Will fix the 9.1.0 issues a little later.
rahulporuri
approved these changes
Nov 8, 2021
Contributor
rahulporuri
left a comment
rahulporuri
left a comment
There was a problem hiding this comment.
Almost LGTM with one question about the regression test
|
|
||
| def test_geometry_filter_works(self): | ||
| # This tests the bug #1071 and segfaults without the fix on VTK 9.x. | ||
| x, y, z, v, s, src = self.get_data() |
Contributor
There was a problem hiding this comment.
it looks like none of these variables are used in this test. can we just remove them?
Member
Author
There was a problem hiding this comment.
Yes, I fixed this now, thanks!
Member
Author
|
Thanks, fixed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were abusing the polys earlier to set the scalar_scatter cell
information but it seems safer and more correct to use the verts. This
fixes #1071.