fix(patch): silence sign-compare warning in sessionVarintGetSafe

jkleinsc · claude · jkleinsc · commit 379d109aae3e · 2026-06-04T16:13:23.000-04:00
Cast int nBuf to size_t when comparing with sizeof(aCopy) so the bundled sqlite3 amalgamation compiles under -Werror,-Wsign-compare. Ref: nodejs/node#62699 Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/patches/node/.patches b/patches/node/.patches
@@ -48,3 +48,4 @@ fix_preserve_node_symbols_and_vtables_under_thinlto.patch
 electron_build-time_v8_code_cache_for_the_electron_js2c_bundles.patch
 electron_enable_node_startup_snapshot_generation_in_chromium_s_v8.patch
 chore_cast_const_away_when_freeing_uv_cpu_info_t_model.patch
+chore_silence_sign-compare_warning_in_sessionvarintgetsafe.patch
diff --git a/patches/node/chore_silence_sign-compare_warning_in_sessionvarintgetsafe.patch b/patches/node/chore_silence_sign-compare_warning_in_sessionvarintgetsafe.patch
@@ -0,0 +1,25 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: John Kleinschmidt <jkleinsc@electronjs.org>
+Date: Mon, 1 Jun 2026 11:39:31 -0400
+Subject: chore: silence sign-compare warning in sessionVarintGetSafe
+
+Upstream sqlite compares signed 'int nBuf' against 'sizeof(aCopy)'
+(size_t). Electron builds with -Wsign-compare as an error, so cast
+nBuf to size_t to silence the warning. Callers always pass a
+non-negative value so this preserves behavior.
+
+This patch can be removed once sqlite fixes the comparison upstream.
+
+diff --git a/deps/sqlite/sqlite3.c b/deps/sqlite/sqlite3.c
+index 91db04a9ecdc54cc4a8c225f91f8dd593e240c2e..235bb054dc356a37281a0406d3952c8e8eb6b47d 100644
+--- a/deps/sqlite/sqlite3.c
++++ b/deps/sqlite/sqlite3.c
+@@ -233670,7 +233670,7 @@ static int sessionVarintGetSafe(const u8 *aBuf, int nBuf, int *piVal){
+   u8 aCopy[9];
+   const u8 *aRead = aBuf;
+   memset(aCopy, 0, sizeof(aCopy));
+-  if( nBuf<sizeof(aCopy) ){
++  if( (size_t)nBuf<sizeof(aCopy) ){
+     memcpy(aCopy, aBuf, nBuf);
+     aRead = aCopy;
+   }
