Expose http timeout setting in Kubernetes package for kube state metrics#19391
Conversation
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
This comment has been minimized.
This comment has been minimized.
| - name: timeout | ||
| type: text | ||
| title: Timeout | ||
| description: HTTP request timeout. Raise on large clusters if scrapes exceed 10s and you see `context deadline exceeded` errors. |
There was a problem hiding this comment.
Valid time units are ns, us, ms, s, m, h.
This is what we have in other timeouts in the integration
This points to this https://github.com/elastic/beats/blob/5f41561f849f0c899682cb5909f1a96dac43b59b/metricbeat/mb/mb.go#L349 beats which validates there.
In case of s is missing it treats this as seconds.
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: 10s |
There was a problem hiding this comment.
qq: why in the screenshot shows 30s?
Did u change the value? just to verify that we dont miss sth
🚀 Benchmarks reportTo see the full report comment with |
This comment has been minimized.
This comment has been minimized.
TL;DRBuildkite failed in Dev scripts unit tests before reaching your Kubernetes changes. The failing test relies on package names that do not exist on the PR base backport branch, so the failure is not caused by the files changed in this PR. Remediation
Investigation detailsRoot Cause
Those call
In this Buildkite run (backport branch context), those package manifests are absent, so the test fails deterministically before validating PR-specific logic. Evidence
Verification
Follow-up
Note 🔒 Integrity filter blocked 2 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
✅ All changelog entries have the correct PR link. |
💚 Build Succeeded
History
|
d62851b
into
elastic:backport-kubernetes-1.83
|
Package kubernetes - 1.83.1 containing this change is available at https://epr.elastic.co/package/kubernetes/1.83.1/ |
…ics (#19662) In large Kubernetes clusters, fetching metrics from kube state metrics can exceed the default HTTP timeout of 10s. This error leads to leader node failures that are unrecoverable. This PR exposes the `timeout` option for KSM datasets, controlling the HTTP timeout. This option is available in Beats and standalone agent. This is a forward-port of #19391 (merged into `backport-kubernetes-1.83`) to `main`.
|
Package kubernetes - 1.85.2 containing this change is available at https://epr.elastic.co/package/kubernetes/1.85.2/ |
Proposed commit message
In large kubernetes cluster, fetching metrics from kube state metrics can exceed the default http timeout of 10s.
This error leads to leader nodes failures that are unrecoverable.
With this PR we expose the timeout option for KSM datasets that controls the http tiemout.
This option is availble in beats and standalone agent.
Checklist
changelog.ymlfile.Screenshots