Skip to content

fix: ObjectCloner.clone may return original object #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebthom merged 1 commit into from
Nov 26, 2025
Merged

fix: ObjectCloner.clone may return original object #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: ObjectCloner.clone may return original object
  • Loading branch information
@sebthom
sebthom committed Nov 26, 2025
commit dfe1c3aaa3adcd1eb649c2efc989b7cf038839ce
2 changes: 1 addition & 1 deletion org.eclipse.tm4e.core/src/main/java/org/eclipse/tm4e/core/internal/utils/ObjectCloner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public final class ObjectCloner {

final var shallowClone = shallowClone(obj, () -> obj);
clones.put(obj, shallowClone);
return obj;
return shallowClone;
}

private static @Nullable <@Nullable T> T deepCloneNullable(final T obj, final Map<Object, @Nullable Object> clones) {
Expand Down