fix: keep Tab-as-spaces indentation on blank lines (LangCfg)#951
Merged
Conversation
Pressing Tab with "Insert spaces for tabs"inserted spaces that were treated like a paste and reindented via `replaceIndent(..., false)`, which returned an empty string and removed the indentation. Skip reindentation for single-line, whitespace-only inserts so user-inserted spaces are preserved on blank lines. Multi-line pastes and non-whitespaceinserts remain unchanged.
sebthom
changed the title
Member
Author
|
@ddscharfe This PR is to address the issue you reported in #949 can you please try to install this snapshot version of TM4E and confirm that the issue is solved: https://github.com/eclipse-tm4e/tm4e/actions/runs/19042992902/artifacts/4452012289 |
Contributor
|
@sebthom That was quick, thanks a lot! This solves the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Tab with "Insert spaces for tabs"inserted spaces that were treated like a paste and reindented via
replaceIndent(..., false), which returned an empty string and removed the indentation.Skip reindentation for single-line, whitespace-only inserts so user-inserted spaces are preserved on blank lines. Multi-line pastes and non-whitespaceinserts remain unchanged.