test(quickstart): fix wagtail hang, reduce job timeout to 60m#8164
Merged
Conversation
|
Download the artifacts for this pull request:
See Testing a PR. |
stasadev
approved these changes
Feb 19, 2026
Member
There was a problem hiding this comment.
This quickstart was originally generated by Claude Code.
And it created the file with CRLF. I don't understand how my git allowed this, but now it uses LF as expected.
Member
Author
There was a problem hiding this comment.
I'm not sure that statement was correct. I think claude was just all confused here. Not sure. I had to clean it up after claude was done with it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
The quickstart CI job was hanging (apparently on the Wagtail test) and not timing out until GitHub's default 360-minute limit.
How This PR Solves The Issue
Root cause: The three
curlcalls at the end ofwagtail.batshad no--max-time. Wagtail is unique among the quickstart tests —web_extra_exposed_portsroutes the entire.ddev.siteURL through gunicorn (aweb_extra_daemonon port 8000) rather than DDEV's normal webserver. Afterddev restart, DDEV waits for the webserver container to be healthy but does not pollweb_extra_daemonsfor readiness. If gunicorn is still initializing, traefik can hold the TCP connection open indefinitely waiting for the backend, causingcurlto hang with no timeout.Changes:
quickstart.yml: Addtimeout-minutes: 60to the job, reducing the maximum hang from 360 minutes to 60 minuteswagtail.bats: Add a gunicorn readiness poll loop (up to 30s) before the HTTP checks, usingddev exec curlinside the container againstlocalhost:8000— the definitive signal gunicorn is readywagtail.bats: Add--max-time 30to all threecurlcalls so a non-responsive backend fails fast with a clear error rather than hangingManual Testing Instructions
Automated Testing Overview
The quickstart CI workflow itself validates these changes.
Release/Deployment Notes
No user-facing changes. CI-only fix.