Skip to content

test(quickstart): fix wagtail hang, reduce job timeout to 60m#8164

Merged
rfay merged 2 commits into
mainfrom
20260219_rfay_wagtail_quickstart_hang
Feb 19, 2026
Merged

test(quickstart): fix wagtail hang, reduce job timeout to 60m#8164
rfay merged 2 commits into
mainfrom
20260219_rfay_wagtail_quickstart_hang

Conversation

@rfay

@rfay rfay commented Feb 19, 2026

Copy link
Copy Markdown
Member

The Issue

The quickstart CI job was hanging (apparently on the Wagtail test) and not timing out until GitHub's default 360-minute limit.

How This PR Solves The Issue

Root cause: The three curl calls at the end of wagtail.bats had no --max-time. Wagtail is unique among the quickstart tests — web_extra_exposed_ports routes the entire .ddev.site URL through gunicorn (a web_extra_daemon on port 8000) rather than DDEV's normal webserver. After ddev restart, DDEV waits for the webserver container to be healthy but does not poll web_extra_daemons for readiness. If gunicorn is still initializing, traefik can hold the TCP connection open indefinitely waiting for the backend, causing curl to hang with no timeout.

Changes:

  • quickstart.yml: Add timeout-minutes: 60 to the job, reducing the maximum hang from 360 minutes to 60 minutes
  • wagtail.bats: Add a gunicorn readiness poll loop (up to 30s) before the HTTP checks, using ddev exec curl inside the container against localhost:8000 — the definitive signal gunicorn is ready
  • wagtail.bats: Add --max-time 30 to all three curl calls so a non-responsive backend fails fast with a clear error rather than hanging

Manual Testing Instructions

Automated Testing Overview

The quickstart CI workflow itself validates these changes.

Release/Deployment Notes

No user-facing changes. CI-only fix.

@rfay rfay requested review from a team as code owners February 19, 2026 17:50
@github-actions

Copy link
Copy Markdown

@stasadev stasadev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread .github/workflows/quickstart.yml Outdated
Comment thread docs/tests/wagtail.bats

@stasadev stasadev Feb 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This quickstart was originally generated by Claude Code.

And it created the file with CRLF. I don't understand how my git allowed this, but now it uses LF as expected.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that statement was correct. I think claude was just all confused here. Not sure. I had to clean it up after claude was done with it here.

@rfay rfay merged commit ac487e6 into main Feb 19, 2026
3 checks passed
@rfay rfay deleted the 20260219_rfay_wagtail_quickstart_hang branch February 19, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants