Skip to content

ci: use skip-package-name-checks, pin golangci-lint to v2.2.1, remove only-new-issues, for #7415 #7416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stasadev merged 2 commits into from
Jun 30, 2025
Merged

ci: use skip-package-name-checks, pin golangci-lint to v2.2.1, remove only-new-issues, for #7415 #7416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a36f1ea
ci: pin `golangci-lint` version, remove `only-new-issues`
stasadev Jun 30, 2025
1c28677
Revert "test: Ignore existing golangci-lint/revive package complaints…
stasadev Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ jobs:
- name: Lint Go Files
uses: golangci/golangci-lint-action@v8
with:
version: latest
# Check code only for the changed lines for PRs
only-new-issues: ${{ github.event_name == 'pull_request' && true || false }}
version: v2.2.1
args: --config=.golangci.yml

check_modules:
Expand Down
7 changes: 7 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ linters:
- -QF1003 # Convert if/else-if chain to tagged switch
- -S1008 # Simplify returning boolean expression
- -S1023 # Omit redundant control flow
revive:
rules:
- name: var-naming
arguments:
- []
- []
- - skip-package-name-checks: true
exclusions:
presets:
- comments
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/remoteconfig/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package remoteconfig //nolint:revive
package remoteconfig

import (
"time"
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/remoteconfig/types/remote_config_storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package types //nolint:revive
package types

import (
"github.com/ddev/ddev/pkg/config/remoteconfig/internal"
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/state/types/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package types //nolint:revive
package types

type StateEntry = interface{}
type StateEntryKey = string
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/state/types/state_storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package types //nolint:revive
package types

// RawState is used to hold a weak type in-memory representation of the state.
type RawState = map[string]any
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/types/xhprof_mode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package types //nolint:revive
package types

import (
"fmt"
Expand Down
2 changes: 1 addition & 1 deletion pkg/globalconfig/types/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package types //nolint:revive
package types

import "github.com/ddev/ddev/pkg/nodeps"

Expand Down
2 changes: 1 addition & 1 deletion pkg/globalconfig/xhprof_mode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package globalconfig //nolint:revive
package globalconfig

import (
"github.com/ddev/ddev/pkg/config/types"
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/errcheck.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package util //nolint:revive
package util

import (
"io"
Expand Down
Loading