fix: allow status code 429 for linkspector#7270
Merged
Merged
Conversation
Member
Author
|
I got the same error in https://github.com/ddev-test/ddev/actions/runs/14863320774/job/41733676200 |
stasadev
changed the title
github_token for linkspector
Member
Author
|
Success with 429 status allowed in https://github.com/ddev-test/ddev/actions/runs/14863503281/job/41734319606 |
rfay
approved these changes
May 6, 2025
rfay
left a comment
rfay
left a comment
Member
There was a problem hiding this comment.
I guess we should do this for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
We get 429 from GitHub links for linkspector https://github.com/ddev/ddev/actions/runs/14861937842/attempts/2
It seems that GitHub changed some limits.
How This PR Solves The Issue
I noticed that we use
GITHUB_TOKENfor actions (this is not the env itself, it's name for custom action variable) instead ofgithub_token(IDE highlighted it for me)Adds an exception for 429 status.
Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes