Skip to content

docs: Remove --no-interaction from Pimcore, disable test, fixes #7243#7245

Merged
rfay merged 1 commit into
ddev:mainfrom
rfay:20250430_rfay_disable_pimcore
May 1, 2025
Merged

docs: Remove --no-interaction from Pimcore, disable test, fixes #7243#7245
rfay merged 1 commit into
ddev:mainfrom
rfay:20250430_rfay_disable_pimcore

Conversation

@rfay

@rfay rfay commented Apr 30, 2025

Copy link
Copy Markdown
Member

The Issue

Pimcore 12.0.0 came out today, and now you can't install without getting a product key.

How This PR Solves The Issue

  • Remove --no-interaction from the quickstart. It gives an odd error about a secret. (With it removed it prompts properly for the key)
  • Skip the pimcore quickstart test. I'm sure we could get a secret for it, but it seems like too much work for right now.

Manual Testing Instructions

Rendered quickstart at https://ddev--7245.org.readthedocs.build/en/7245/users/quickstart/#pimcore

  • Test the updated quickstart manually

Automated Testing Overview

Release/Deployment Notes

@rfay rfay requested review from rpkoller and stasadev April 30, 2025 18:53
@rfay rfay marked this pull request as ready for review April 30, 2025 18:53
@rfay rfay requested a review from a team as a code owner April 30, 2025 18:53

@stasadev stasadev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rfay rfay merged commit 902385d into ddev:main May 1, 2025
@rfay rfay deleted the 20250430_rfay_disable_pimcore branch May 1, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants