Skip to content

test: add timeout to buildkite maintenance, fixes #7176#7226

Merged
rfay merged 2 commits into
mainfrom
20250424_test_buildkite_timeout
Apr 29, 2025
Merged

test: add timeout to buildkite maintenance, fixes #7176#7226
rfay merged 2 commits into
mainfrom
20250424_test_buildkite_timeout

Conversation

@rfay

@rfay rfay commented Apr 24, 2025

Copy link
Copy Markdown
Member

The Issue

Random docker or network fails shouldn't tie up the test runner forever.

How This PR Solves The Issue

  • Minor refactoring, pushing a few actions into testbot_maintenance.sh
  • Add timeout on call to testbot_maintenance.sh

Manual Testing Instructions

Look carefully at buildkite output on mac, WSL2, Windows.

@rfay rfay marked this pull request as ready for review April 24, 2025 18:21
@rfay rfay requested a review from a team as a code owner April 24, 2025 18:21
@rfay rfay requested a review from stasadev April 24, 2025 18:21

@stasadev stasadev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also can get stuck here

# Test that docker can allocate 80 and 443, get busybox
docker pull busybox:stable >/dev/null

@rfay rfay requested a review from stasadev April 29, 2025 01:43

@stasadev stasadev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@rfay rfay merged commit 4717152 into main Apr 29, 2025
@rfay rfay deleted the 20250424_test_buildkite_timeout branch April 29, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants