Skip to content

fix: Improve the output of ArrayToReadableOutput#7222

Merged
rfay merged 2 commits into
ddev:mainfrom
rfay:20250422_rfay_improve_overrides
Apr 23, 2025
Merged

fix: Improve the output of ArrayToReadableOutput#7222
rfay merged 2 commits into
ddev:mainfrom
rfay:20250422_rfay_improve_overrides

Conversation

@rfay

@rfay rfay commented Apr 22, 2025

Copy link
Copy Markdown
Member

The Issue

I've long been annoyed by the output of ArrayToReadableOuput, think we can do better

How This PR Solves The Issue

Old config override notification:

Using custom nginx configuration in /home/rfay/workspace/d11/.ddev/nginx_full/nginx-site.conf
Using custom PHP configuration: [
        /home/rfay/workspace/d11/.ddev/php/xxx.ini
]
Using custom web-build configuration: [
        /home/rfay/workspace/d11/.ddev/web-build/Dockerfile.nothing
        /home/rfay/workspace/d11/.ddev/web-build/Dockerfile.nothing2
]

New config override notification:

rfay@ubuntu-len:~/workspace/d11$ ddev start
Starting d11...
Using custom PHP configuration:
  - /home/rfay/workspace/d11/.ddev/php/xxx.ini

Using custom web-build configuration:
  - /home/rfay/workspace/d11/.ddev/web-build/Dockerfile.nothing
  - /home/rfay/workspace/d11/.ddev/web-build/Dockerfile.nothing2

Old startup failure notification:

Waiting for containers to become ready: [web db]
Failed waiting for web/db containers to become ready: web container failed: log=, err=ddev-d11-web container is unhealthy, log=
Troubleshoot this with these commands:
[
        ddev logs -s web
        docker logs ddev-d11-web
        docker inspect --format "{{ json .State.Health }}" ddev-d11-web | docker run -i --rm ddev/ddev-utilities jq -r
]

New startup failure notification:

Waiting for containers to become ready: [web db]
Failed waiting for web/db containers to become ready: web container failed: log=, err=ddev-d11-web container is unhealthy, log=
Troubleshoot this with these commands:

  - ddev logs -s web
  - docker logs ddev-d11-web
  - docker inspect --format "{{ json .State.Health }}" ddev-d11-web | docker run -i --rm ddev/ddev-utilities jq -r

Manual Testing Instructions

  • Add some config override and see what happens.
  • You can break the startup by adding "xxx;" to .ddev/nginx_full/nginx-site.conf in the server section and removing #ddev-generated.

Automated Testing Overview

Release/Deployment Notes

@github-actions

github-actions Bot commented Apr 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Download the artifacts for this pull request:

See Testing a PR.

Open in GitHub Codespaces

@rfay rfay marked this pull request as ready for review April 23, 2025 00:35
@rfay rfay requested a review from a team as a code owner April 23, 2025 00:35
@rfay rfay requested a review from stasadev April 23, 2025 00:35
stasadev
stasadev approved these changes Apr 23, 2025
View reviewed changes

@stasadev stasadev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it's much more user-friendly!

@rfay rfay merged commit 51bb420 into ddev:main Apr 23, 2025
@rfay rfay deleted the 20250422_rfay_improve_overrides branch April 23, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stasadev stasadev stasadev approved these changes

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rfay @stasadev