test: improve ddev debug test#7128
Merged
Merged
Conversation
|
Download the artifacts for this pull request:
See Testing a PR.
|
rfay
approved these changes
Mar 20, 2025
|
|
||
| if [[ ${PWD} != ${HOME}* ]]; then | ||
| printf "\n\nWARNING: Project should usually be in a subdirectory of the user's home directory.\nInstead it's in ${PWD}\n\n" | ||
| printf "\n\nWARNING: Project should usually be in a subdirectory of the user's home directory.\nInstead it's in %s\n\n" "${PWD}" |
Member
There was a problem hiding this comment.
Not sure why to make these printf changes, but they're fine.
Member
Author
There was a problem hiding this comment.
I followed this recommendation https://github.com/koalaman/shellcheck/wiki/SC2059
| echo | ||
| if [ -f .ddev/mutagen/mutagen.yml ]; then | ||
| if grep '#ddev-generated' .ddev/mutagen/mutagen.yml; then | ||
| if grep -q '#ddev-generated' .ddev/mutagen/mutagen.yml; then |
Member
There was a problem hiding this comment.
Excellent. I always do >/dev/null and -q is better. And regardless, it's good to lose that output here.
Co-authored-by: Randy Fay <randy@randyfay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
ddev debug testcreates test project, which is probably included to instrumentationcurlon host runs without explicit timeoutHow This PR Solves The Issue
export DDEV_NO_INSTRUMENTATION=trueinside the script.DOCKER_HOST="" docker context lswith empty DOCKER_HOST (because it always shown as a warning, but we set this variable ourselves in DDEV).printfwarnings shown to me in the IDE.docker system dfoutput with tips how to clean it.ddev versionifDDEV_NO_INSTRUMENTATION=true.curl --connect-timeout 10 --max-time 20on the host to prevent people from using^C.Manual Testing Instructions
Run
ddev debug testAutomated Testing Overview
Release/Deployment Notes