test: adjust openmage bats test assertions to the now available demo content#7126
Conversation
|
@sreichel from your perspective what would be the best approach to stick to with the quickstart? i know we've talked about composer before and you wrote something like the composer approach isnt recommended at this point for openmage and the git based approach would be more robust but providing a version of openmage head (as outlined in the issue summary) seems still a bit challenging in particular you have less technical folks who want to just try openmage and are unaware of the implications. update: @stasadev just dug up OpenMage/magento-lts#4709 ... so would be probably the best way forward to wait until the aforementioned PR is in and then update the quickstart and test switching to a composer based approach? and thank you for already opening an issue for that bringing the composer based approach en par. |
|
I am busy atm, so i'll pass it to @kiatng @colinmollenhour @addison74 I'm not sure whats the best way to make custom DDEV-commands available for composer install. The live inside OM. (OpenMage/magento-lts#4709). For quickstart composer-install I think the easiest way is to use plain CLI install command, instead of Please give me some days to think about it. And, much thanks for all your help :) |
4 participants
The Issue
according to randy tests were failing on main for the openmage bats test. turn out the assertion testing the frontend was failing the test. well turns out the fix by stas got already merged OpenMage/magento-lts#4720 and due to the fact the test and quickstart is using
git clone https://github.com/OpenMage/magento-lts .the fix was already available that way the demo site is completely different:adjusted the assertion to the now working demo content. only question is is it a good idea to recommend a quickstart that is living on the edge aka the head for openmage? ( a good thing in case of the bug but in the long run for less technical folks getting in touch with openmage for the first time i am unsure)
How This PR Solves The Issue
Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes