build: stop installing chocolatey, fixes #6636, fixes #6344 [skip buildkite] by colans · Pull Request #7049 · ddev/ddev

colans · 2025-03-05T16:22:09Z

The Issue

Update WSL installation scripts to stop using Chocolatey #6636
Support Windows and WSL2 ARM64 #6344 (I think this is the final fix for Windows ARM64, stopping use of Choco)

We no longer need Chocolatey when installing inside WSL so let's remove it to prevent side effects that users are running into.

How This PR Solves The Issue

It removes the unnecessary dependency.

Manual Testing Instructions

Run the script to install DDEV.
Ensure that there are no errors caused by Chocolatey not being installed.
Ensure that DDEV works.

Automated Testing Overview

TBD

Release/Deployment Notes

TBD

rfay · 2025-03-05T17:27:06Z

Making progress!

When we don't install chocolatey, we need to remove the choco install features
We need to replace those with an alternate installation technique (ddev.exe, mkcert.exe, and gsudo.exe still need to be installed on the Windows side
This needs to be done to both the Docker CE install script and the Docker Desktop install script

I don't know how to do automated testing on this, and we currently don't have any.

colans · 2025-03-05T18:38:52Z

Yup, the first two of those are what I'm working on now (trying to figure out how to do this stuff in Powershell as I come from the Linux world).

Didn't know about that 3rd item so I'll look into that too!

colans · 2025-03-05T18:41:00Z

@rfay : Where should I stick these EXEs after downloading?

colans · 2025-03-05T19:34:26Z

Where should I stick these EXEs after downloading?

I just created a new DDEV directory in Program Files.

What's left:

Installing mkcert, and
Doing the other script.

colans · 2025-03-05T22:24:04Z

I just created a new DDEV directory in Program Files.

In the end, I just ended up with a mkcert directory because the other apps use installers. We're not actually placing the binaries anywhere; the installers take care of that.

Anyway, just took this out of draft; it's ready for review.

rfay

I'm afraid I misled you and didn't think properly about mkcert and gsudo, and you're doing the right thing with the installer. So mkcert/gsudo get installed by the installer (I think).

You'll find lots of examples of how to download latest stable version of a package.

Please make sure this handles the architecture correctly. It should be able to handle windows amd64 and arm64.

rfay · 2025-03-06T15:01:25Z

Please use [skip buildkite] in your commit messages (if you remember, no harm done if you don't) since this doesn't run any tests on buildkite. I'm not sure why they ran anyway, some rule must be wrong.

rfay · 2025-03-06T17:44:30Z

Rebased this so you won't get messed up by changes to these scripts that went into upstream/main - make sure you get the latest version before continuing, thanks.

colans · 2025-03-06T19:32:24Z

Next up is fetching the correct architecture...

colans · 2025-03-07T17:41:52Z

@rfay Ready for your review again:

Apps that the installer pulls in are no longer installed explicitly.
The release is no longer hard-coded.
The architecture is no longer hard-coded.
Code is now the same for both scripts.

rfay

Looking pretty great, looking forward to test drive.

rfay · 2025-03-11T13:36:43Z

Sorry I haven't gotten to manually test yet, will get there. I just haven't spent a day with spare time on WSL2 in the last bit. As you know from your work, it's a lot of work to test.

One thing I've been thinking about... it may not need to run in admin PS, true? Depends on what the behavior or the DDEV installer is in this situation.

rfay · 2025-03-11T13:37:36Z

Rebased

rfay

I tested both of these scripts and they worked fine.

There are a couple of things to be done:

Currently, this runs the ddev installer and people have to step through it. I think that's OK, but if we're going to leave it like that we need to change the installer to not have that "open release notes" at the end by default, because that opens a browser that hides what happens from there.
What do you think about running the installer in silent mode like chocolatey does? Run the installer with /S /C
I'm pretty sure this no longer needs to be run in admin Powershell, do you agree? Perhaps the silent mode conflicts with that idea. But if it doesn't need to be run in silent mode then the doc has to be improved.

Awesome work, just what I was hoping for!

colans · 2025-03-18T14:06:17Z

Thanks for reviewing! I was away last week so will catch up on the above soon.

rfay · 2025-03-18T14:09:03Z

Thank you for working on this, it's going to be really great. I apologize for requesting other things here, but we want to make this as easy to use as possible.

colans · 2025-03-25T16:11:35Z

Currently, this runs the ddev installer and people have to step through it. I think that's OK, but if we're going to leave it like that we need to change the installer to not have that "open release notes" at the end by default, because that opens a browser that hides what happens from there.

How do you think we should implement this? If it's running from either of the Windows installers, skip that step? Is this context available to the installer?

What do you think about running the installer in silent mode like chocolatey does? Run the installer with /S /C

I don't like running things in silent mode because then you can't see what's happening, and if something goes wrong, then you don't know what went wrong. Maybe Windows users are accustomed to this, but it drives me nuts. (I run Ansible playbooks with "-vv" so that's my bias; I like to know what's going on.)

I'm pretty sure this no longer needs to be run in admin Powershell, do you agree? Perhaps the silent mode conflicts with that idea. But if it doesn't need to be run in silent mode then the doc has to be improved.

When you tested it, did you try it without? I haven't had a chance to get back into this yet. Let's have at least one of us try it without, and see if it works. That should be good enough of a test, right? If so, we update the docs. Otherwise, I think we can drop this one.

rfay · 2025-03-25T20:51:18Z

How do you think we should implement this? If it's running from either of the Windows installers, skip that step? Is this context available to the installer?

I think all you have to do is this, but I'm on mac right now need to check the build. make windows will build the windows installer:

diff --git a/winpkg/ddev.nsi b/winpkg/ddev.nsi
index 0103c38b3..bf540987d 100644
--- a/winpkg/ddev.nsi
+++ b/winpkg/ddev.nsi
@@ -226,6 +226,7 @@ Var ICONS_GROUP
 
 ; Finish page
 !define MUI_FINISHPAGE_SHOWREADME "${PRODUCT_RELEASE_NOTES_URL}"
+!define MUI_FINISHPAGE_SHOWREADME_NOTCHECKED
 !define MUI_FINISHPAGE_SHOWREADME_TEXT "Review the release notes"
 !define MUI_FINISHPAGE_LINK "${PRODUCT_PROJECT} (${PRODUCT_PROJECT_URL})"
 !define MUI_FINISHPAGE_LINK_LOCATION ${PRODUCT_PROJECT_URL}

I don't like running things in silent mode because then you can't see what's happening, and if something goes wrong, then you don't know what went wrong. Maybe Windows users are accustomed to this, but it drives me nuts. (I run Ansible playbooks with "-vv" so that's my bias; I like to know what's going on.)

Agreed, although choco installs are classically that way. If we add a statement like "Press return to continue the DDEV WIndows-side installer, which is only used to update the hosts file, just accept the defaults" then they won't be surprised.

When you tested it, did you try it without? I haven't had a chance to get back into this yet. Let's have at least one of us try it without, and see if it works. That should be good enough of a test, right? If so, we update the docs. Otherwise, I think we can drop this one.

I have not tested it that way yet, but have high hopes.

rfay · 2025-03-25T22:28:19Z

I did the NSIS (ddev.nsi) fix in

fix: don't auto show release notes in windows installer, for #7049 #7147

So you don't have to think about that. Tested locally and it works. Please consider whether silent-install is worth considering since we only are installing this in order to edit hostnames (when doing WSL2)

…7147)

rfay · 2025-03-26T16:47:36Z

Rebased; the fix to the Windows DDEV installer is now in HEAD and will be in release hopefully on Friday.

rfay · 2025-04-09T16:56:22Z

My first guess is that the silent installation skips mkcert; here's what I see with non-silent:

rfay · 2025-04-09T16:57:55Z

Here's the reason:

ddev/winpkg/ddev.nsi

Lines 500 to 505 in 4f00610

    
             Section "mkcert" SecMkcert 
        
               ; Install in non choco mode only 
        
               ${IfNot} ${Chocolatey} 
        
                 SectionIn 1 2 
        
                 SetOutPath "$INSTDIR" 
        
                 SetOverwrite try

…ert [skip buildkite]

…ldkite]

rfay · 2025-04-09T17:45:49Z

For some reason the installer can't be pre-emptively removed. Can you take a look at this @colans and maybe see if it can be installed with a unique name, or escalate, or something?

PS C:\Users\randy\workspace\ddev.windows\scripts> .\install_ddev_wsl2_docker_inside.ps1
Detected OS architecture: AMD64; using DDEV installer: amd64
The latest ddev/ddev version is v1.24.4.
Downloading from https://github.com/ddev/ddev/releases/download/v1.24.4/ddev_windows_amd64_installer.v1.24.4.exe...
Remove-Item : Cannot remove item C:\Users\randy\AppData\Local\Temp\ddev-installer.exe: Access to the path
'C:\Users\randy\AppData\Local\Temp\ddev-installer.exe' is denied.
At C:\Users\randy\workspace\ddev.windows\scripts\install_ddev_wsl2_docker_inside.ps1:87 char:1
+ Remove-Item $DdevInstallerPath
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : PermissionDenied: (C:\Users\randy\...v-installer.exe:FileInfo) [Remove-Item], UnauthorizedAccess
   Exception
    + FullyQualifiedErrorId : RemoveFileSystemItemUnAuthorizedAccess,Microsoft.PowerShell.Commands.RemoveItemCommand

github-actions · 2025-04-09T17:58:46Z

Download the artifacts for this pull request:

See Testing a PR.

github-actions · 2025-04-09T18:45:49Z

Download the artifacts for this pull request:

See Testing a PR.

colans · 2025-04-09T18:52:50Z

Having unique installer names is a good move so deleting is no longer our problem. I usually go with something like filename-timestamp.ext, but GUIDs work too. 😉 Thanks for figuring it out!

rfay · 2025-04-09T19:16:34Z

I think it might work now, your review is appreciated. Apparently the mkcert wasn't installed immediately; it now waits for completion. No idea why.

It also now works with the current released installer; but the uninstall won't uninstall without the complaint until the next release (it tries to remove the directory when there's still a file in it). But the new installer does remove successfully.

I'm not sure if there might be a way for the script to get the installer that is the same commit hash, but that sounds exotic.

github-actions · 2025-04-09T19:19:00Z

Download the artifacts for this pull request:

See Testing a PR.

stasadev

I tested install_ddev_wsl2_docker_inside.ps1 - works fine.

I didn't test install_ddev_wsl2_docker_desktop.ps1 (My VM with Dockrt Desktop is broken, internet doesn't work, so I need to recreate it from scratch.)

github-actions · 2025-04-10T14:33:55Z

Download the artifacts for this pull request:

See Testing a PR.

rfay · 2025-04-10T14:36:19Z

Fingers crossed! Thanks for the great work here @colans !

rfay · 2025-04-10T15:26:17Z

I didn't think about the fact that people will be using the stable docs, but getting this script already (from main). So they'll think they have to run it with admin privs, but of course @colans checked it that way and it worked. Hopefully it will be OK!

github-actions Bot added the maintenance label Mar 5, 2025

colans marked this pull request as ready for review March 5, 2025 22:24

colans requested a review from a team as a code owner March 5, 2025 22:24

rfay requested changes Mar 6, 2025

View reviewed changes

Comment thread scripts/install_ddev_wsl2_docker_desktop.ps1 Outdated

Comment thread scripts/install_ddev_wsl2_docker_desktop.ps1 Outdated

Comment thread scripts/install_ddev_wsl2_docker_desktop.ps1 Outdated

Comment thread scripts/install_ddev_wsl2_docker_desktop.ps1 Outdated

rfay changed the title ~~build: stop installing chocolatey, fixes #6636~~ build: stop installing chocolatey, fixes #6636 [skip buildkite] Mar 6, 2025

rfay force-pushed the 6636-stop-installing-chocolatey branch from 91a1362 to d2d851b Compare March 6, 2025 17:43

rfay reviewed Mar 7, 2025

View reviewed changes

rfay force-pushed the 6636-stop-installing-chocolatey branch from d6a27b2 to 7e3b0d7 Compare March 11, 2025 13:37

rfay requested changes Mar 12, 2025

View reviewed changes

rfay added a commit to rfay/ddev that referenced this pull request Mar 25, 2025

fix: don't auto show release notes in windows installer, for ddev#7049

f219a99

rfay mentioned this pull request Mar 25, 2025

fix: don't auto show release notes in windows installer, for #7049 #7147

Merged

rfay added a commit that referenced this pull request Mar 26, 2025

fix: don't auto show release notes in windows installer, for #7049 (#…

4f00610

…7147)

rfay force-pushed the 6636-stop-installing-chocolatey branch from 7e3b0d7 to 3bf49b0 Compare March 26, 2025 16:47

Remove choco suggestion from docker desktop installer [skip buildkite]

28a1b27

rfay changed the title ~~build: stop installing chocolatey, fixes #6636 [skip buildkite]~~ build: stop installing chocolatey, fixes #6636, fixes #6344 [skip buildkite] Apr 9, 2025

rfay added 3 commits April 9, 2025 11:06

Experimental: remove ChocolateyMode completely and always install mkc…

34c5914

…ert [skip buildkite]

Put back chocolatey mode, but only skip mkcert in that mode [skip bui…

d6ed039

…ldkite]

Change sudo_license to gsudo_license [skip buildkite]

8aec8b5

rfay added 7 commits April 9, 2025 12:02

Keep ChocolateyMode but don't use [skip buildkite]

b4f577f

Use unique name for installer, thanks to chatgpt [skip buildkite]

9354eb7

same changes to docker desktop script [skip buildkite]

48cdfdf

Delete existing installers [skip buildkite]

bf4b3c6

Add cleanup to docker-inside script [skip buildkite]

82bfa61

Remove the remove-item as not needed [skip buildkite]

ae08a20

Make sure DDEV dir is in PATH to use mkcert [skip buildkite]

d4a44a2

Use mkcert.exe [skip buildkite]

641b1f2

rfay added 2 commits April 9, 2025 13:01

Execute explicitly with path [skip buildkite]

21ddd48

Why isn't mkcert there yet? [skip buildkite]

7189d5e

stasadev approved these changes Apr 9, 2025

View reviewed changes

Comment thread docs/content/users/install/ddev-installation.md Outdated

rfay added 2 commits April 9, 2025 19:24

Fix numbering in doc that is in tab [skip buildkite]

f7ccc28

More renumbering [skip buildkite]

cd443ed

rfay merged commit 0c9f41e into ddev:main Apr 10, 2025

Uh oh!

Uh oh!

Conversation

colans commented Mar 5, 2025 • edited by rfay Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The Issue

How This PR Solves The Issue

Manual Testing Instructions

Automated Testing Overview

Release/Deployment Notes

Uh oh!

rfay commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

colans commented Mar 5, 2025

Uh oh!

colans commented Mar 5, 2025

Uh oh!

colans commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

colans commented Mar 5, 2025

Uh oh!

rfay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rfay commented Mar 6, 2025

Uh oh!

rfay commented Mar 6, 2025

Uh oh!

colans commented Mar 6, 2025

Uh oh!

colans commented Mar 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfay left a comment

Choose a reason for hiding this comment

Uh oh!

rfay commented Mar 11, 2025

Uh oh!

rfay commented Mar 11, 2025

Uh oh!

rfay left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

colans commented Mar 18, 2025

Uh oh!

rfay commented Mar 18, 2025

Uh oh!

colans commented Mar 25, 2025

Uh oh!

rfay commented Mar 25, 2025

Uh oh!

rfay commented Mar 25, 2025

Uh oh!

rfay commented Mar 26, 2025

Uh oh!

rfay commented Apr 9, 2025

Uh oh!

rfay commented Apr 9, 2025

Uh oh!

rfay commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

colans commented Apr 9, 2025

Uh oh!

rfay commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

stasadev left a comment

colans commented Mar 5, 2025 •

edited by rfay

Loading

rfay commented Mar 5, 2025 •

edited

Loading

colans commented Mar 5, 2025 •

edited

Loading

colans commented Mar 7, 2025 •

edited

Loading

rfay left a comment •

edited

Loading

rfay commented Apr 9, 2025 •

edited

Loading