refactor: use ddev composer create-project in the code, for #6920#7027
Conversation
|
Download the artifacts for this pull request:
See Testing a PR. |
|
I know this is 100% great but it touches so many things I'll have to spend a little time with it. |
|
The "solution" section of the linked issue starts
Is 43% enough? I'm worried that over half of users are still on earlier versions. |
|
I can update everything for now without touching This way, it will be an easy switch in the future, allowing us to make changes step by step. |
63e7e99 to
4b093d6
Compare
ddev composer create-project everywhere, fixes #6920ddev composer create-project in the code, for #6920
|
Thanks, @GuySartorelli! The changes made here should be easy to understand now, and it will be much simpler to update our quickstarts later without needing to review a massive PR. |
|
And note that the changes to the quickstart don't go to "stable", the only place we expect them to show up, until the next release (late March, hopefully). Today's situation: https://app.amplitude.com/analytics/share/a0fde21314e34378831943af7f9dd022 |
GuySartorelli
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
The Issue
ddev composer create-projecteverywhere #692043% of people are already using v1.24.2 and we expect more people to upgrade to v1.24.3.
https://app.amplitude.com/analytics/share/a0fde21314e34378831943af7f9dd022
How This PR Solves The Issue
Hides
ddev composer createfrom autocompletion andddev help composer.Adds
ddev composer create-projectto autocompletion andddev help composer.Replaces this in the code (excluding quickstarts):
Adds exclusions for ".idea", ".vscode" in addition to ".ddev", ".git", ".tarballs".
Manual Testing Instructions
Automated tests should just pass.
Automated Testing Overview
Release/Deployment Notes