Skip to content

refactor: use ddev composer create-project in the code, for #6920#7027

Merged
rfay merged 4 commits into
mainfrom
20250227_stasadev_composer_create_project
Mar 5, 2025
Merged

refactor: use ddev composer create-project in the code, for #6920#7027
rfay merged 4 commits into
mainfrom
20250227_stasadev_composer_create_project

Conversation

@stasadev

@stasadev stasadev commented Feb 26, 2025

Copy link
Copy Markdown
Member

The Issue

43% of people are already using v1.24.2 and we expect more people to upgrade to v1.24.3.

https://app.amplitude.com/analytics/share/a0fde21314e34378831943af7f9dd022

How This PR Solves The Issue

Hides ddev composer create from autocompletion and ddev help composer.
Adds ddev composer create-project to autocompletion and ddev help composer.

Replaces this in the code (excluding quickstarts):

-ddev composer create vendor/package:^a.b
+ddev composer create-project vendor/package . "^a.b"

Adds exclusions for ".idea", ".vscode" in addition to ".ddev", ".git", ".tarballs".

Manual Testing Instructions

Automated tests should just pass.

Automated Testing Overview

Release/Deployment Notes

@github-actions

github-actions Bot commented Feb 26, 2025

Copy link
Copy Markdown

@stasadev stasadev marked this pull request as ready for review February 27, 2025 08:46
@stasadev stasadev requested review from a team as code owners February 27, 2025 08:46
@rfay

rfay commented Feb 27, 2025

Copy link
Copy Markdown
Member

I know this is 100% great but it touches so many things I'll have to spend a little time with it.

@GuySartorelli

Copy link
Copy Markdown
Contributor

The "solution" section of the linked issue starts

After most people use DDEV v1.24.2+, we can make the following changes

Is 43% enough? I'm worried that over half of users are still on earlier versions.

@stasadev

stasadev commented Feb 28, 2025

Copy link
Copy Markdown
Member Author

I can update everything for now without touching quickstart.md (and its tests), if that makes sense.

This way, it will be an easy switch in the future, allowing us to make changes step by step.

@stasadev stasadev force-pushed the 20250227_stasadev_composer_create_project branch from 63e7e99 to 4b093d6 Compare February 28, 2025 13:55
@stasadev stasadev changed the title refactor: use ddev composer create-project everywhere, fixes #6920 refactor: use ddev composer create-project in the code, for #6920 Feb 28, 2025
@stasadev

Copy link
Copy Markdown
Member Author

Thanks, @GuySartorelli!

The changes made here should be easy to understand now, and it will be much simpler to update our quickstarts later without needing to review a massive PR.

@rfay

rfay commented Feb 28, 2025

Copy link
Copy Markdown
Member

And note that the changes to the quickstart don't go to "stable", the only place we expect them to show up, until the next release (late March, hopefully).

Today's situation: https://app.amplitude.com/analytics/share/a0fde21314e34378831943af7f9dd022

@GuySartorelli GuySartorelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@rfay rfay merged commit 6999cbc into main Mar 5, 2025
@rfay rfay deleted the 20250227_stasadev_composer_create_project branch March 5, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants