fix: remove refreshenv from WSL2 install scripts, fixes #7024 [skip ci]#7026
Merged
Conversation
4 tasks
Member
Author
|
I imagine this is totally fine but will need to run through both scripts with a clean new WSL2 instance before pulling. |
rfay
force-pushed
the
20250226_rfay_wsl_install
branch
from
03851d3 to
e222b9e
Compare
rfay
commented
Mar 6, 2025
rfay
left a comment
rfay
left a comment
Member
Author
There was a problem hiding this comment.
I manually tested both of these from scratch, and they seem to be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
wmic not foundwhen running DDEV WSL2 install script #7024In some new Windows 11 versions,
wmic.exeis either not installed or not in the PATH.It's also part of a deprecated subsystem.
How This PR Solves The Issue
refreshenvthat happened to call this from the two WSL2 install scriptssystem service docker startthat was in there.Manual Testing Instructions
Use a fresh clean Ubuntu as the default WSL2.
Install in both contexts (docker-ce and Docker Desktop), with
wmicout of the path, as described in the issue.Automated Testing Overview
There is no testing for this.