fix: the #ddev-description stanza in add-on install actions not showing if it's the first line#7022
Merged
Merged
Conversation
hanoii
changed the title
#ddev-description in add-on install actions not showing
hanoii
changed the title
#ddev-description in add-on install actions not showing #ddev-description in add-on install actions not showing
hanoii
changed the title
#ddev-description in add-on install actions not showingddev-description in add-on install actions not showing
hanoii
changed the title
ddev-description in add-on install actions not showing#ddev-description stanza in add-on install actions not showing if it's the first line
|
Download the artifacts for this pull request:
See Testing a PR.
|
rfay
approved these changes
Feb 26, 2025
rfay
left a comment
rfay
left a comment
Member
There was a problem hiding this comment.
Looks safe to me. Do you think this was a regression, or just an oversight? I do hope we can find more sophisticated ways to do this sort of thing in the future.
Collaborator
Author
|
According to blame this goes back to 2 years so maybe it was an oversight. |
Collaborator
Author
|
Also in looking in the issue queue as I vaguely remember this being an issue before, I found #5277, which although not the same thing, it's worth linking the two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed that my add-on's post install actions were not showing the
#ddev-descriptionas I was used to.I looked at the code and found that the regex was not finding it if the stanza was right next to
- |. One more newline and it was picked up.I added an extra newline on the last commit of that file, but trying it with the latest release of the add-on show showcase the issue.