Add type annotations for chunks parameter in from_array and rechunk#12429
Open
omarwael-24 wants to merge 12 commits into
Open
Add type annotations for chunks parameter in from_array and rechunk#12429omarwael-24 wants to merge 12 commits into
omarwael-24 wants to merge 12 commits into
Conversation
Adding a type hints for chunks parameter
omarwael-24
force-pushed
the
fix-chunks-type-hints
branch
from
df66a6b to
fc4bdde
Compare
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files ±0 25 suites ±0 7h 0m 48s ⏱️ + 1m 31s Results for commit fc4bdde. ± Comparison against base commit a588170. |
crusaderky
requested changes
Jun 4, 2026
crusaderky
left a comment
crusaderky
left a comment
Collaborator
There was a problem hiding this comment.
you pushed your whole venv/.
Please
- remove it from your branch
- merge from main
- ensure that
pixi run lintpasses - manually go through all of your changes and ensure that you (a human) are satisfied with them, in other words everything passes your own review
- ping me again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive type hints for the
chunksparameter in bothdask/array/core.py(from_arrayfunction) anddask/array/rechunk.py(rechunkfunction).Using
Anyand internal type adjustments handles the complex dynamic behavior of thechunksparameter across Dask's internal codebase while maintaining proper static verification.Checklist
pixi run lint