Ignore exclusions inside multiline strings#2177
Closed
puneetdixit200 wants to merge 1 commit into
Closed
Conversation
Member
|
I'm wondering if multiline is important here, or if there are cases where a single line string would also cause a false match. I'm also curious why you use such long tortuous test lines when |
puneetdixit200
force-pushed
the
fix-ellipsis-string-exclusion
branch
from
9cc4675 to
d588cb6
Compare
Member
|
Why did you close this PR? |
Author
|
I closed this one because I replaced it with #2180 after your feedback. The newer PR adds the single-line string case, keeps the multiline coverage, and has the updated validation/results in the PR body. |
Member
|
OK, for the future, you don't need to close the first PR, you can keep pushing changes to your branch no matter how large the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
..., which should still count the assignment as executableTests:
PYTHONWARNDEFAULTENCODING= /tmp/coveragepy-venv/bin/python -m pytest -q tests/test_coverage.py::ExcludeTest::test_default_ellipsis_exclusion_ignores_multiline_strings tests/test_coverage.py::ExcludeTest::test_default tests/test_parser.py::ExclusionParserTest::test_over_exclusion_bug1779PYTHONWARNDEFAULTENCODING= /tmp/coveragepy-venv/bin/python -m pytest -q tests/test_coverage.py::ExcludeTestPYTHONWARNDEFAULTENCODING= /tmp/coveragepy-venv/bin/python -m pytest -q tests/test_parser.py::ExclusionParserTest/tmp/coveragepy-venv/bin/python -m compileall -q coverage/parser.py tests/test_coverage.pygit diff --checkFixes #2112