Platform specific configuration and Environment variable expansion#77
Merged
Conversation
colinta
reviewed
Mar 17, 2017
| def settings(self): | ||
| return sublime.load_settings('FileDiffs.sublime-settings') | ||
| def get_setting(self, key, default=None): | ||
| print('FileDiffs.sublime-settings') |
Owner
There was a problem hiding this comment.
Small thing, but could you remove this print?
Contributor
Author
There was a problem hiding this comment.
Sure, it was for a debug purpose.
I forgot to remove it. My bad.
Owner
|
Looks great! Just gonna wait on removing the debug |
Contributor
Author
|
Done :-) |
Owner
|
Thanks! I pushed this up as 2.8.0. It just now occurred to me that we should mention this feature in the README. |
Contributor
Author
|
True! I created another PR #78 for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In this PR, there is two new features:
(Platform settings take precedence on generic settings)
(Replace environment variable in path set in the configuration files)
Thank you