1337 add a meetings block for wp block themes by anchovie91471 · Pull Request #1383 · code4recovery/12-step-meeting-list

anchovie91471 · 2024-03-09T14:39:04Z

Renders all TSML shortcodes as Gutenberg blocks.

TSML UI (both versions)
Regions list
Upcoming meetings
Types list

Currently, this PR generates 2 files in the plugin root when running npx mix --production or npx mix watch (undefined.js & undefined.asset.php). These are unnecessary, and were added to the .gitignore as a stop gap, but this is not ideal. Hoping to get some assistance on finding a better way to compile assets or to fix the anomalous files being generated.
`

…files - Removed @tinypixelco/laravel-mix-wp-blocks & @wordpress/dependency-extraction-webpack-plugin dependencies - Added @wordpress/scripts dependency - Moveed render.php to block directory (best practice) - Set .gitignore, webpack.mix.js & mix-manifest.json back to original content

joshreisner

left a few minor questions

this seems great, i was able to embed the block

i then struggled mightily trying to get it to go wider in 2024 and couldn't, but i don't think that can be helped by us, right? there's no way to make it easier to go wider?

it would be great if we could make a loom or other short screencast video showing how to make the block wider and link it from the description, but that can be in a future PR

joshreisner

oh ok i see your response - i'd like to discuss this a little before merging

anchovie91471 · 2024-03-23T15:09:40Z

The align toolbar is where you set the width/alignment. I agree, a screenshot at the very least or a short vid might be helpful. I think people who are comfortable with the block editor might know where to look.

I am going to push one more commit to the PR to set .gitignore and webpack.mix.js back to the original files. It looks like my IDE converted tabs to spaces.

left a few minor questions

this seems great, i was able to embed the block

i then struggled mightily trying to get it to go wider in 2024 and couldn't, but i don't think that can be helped by us, right? there's no way to make it easier to go wider?

it would be great if we could make a loom or other short screencast video showing how to make the block wider and link it from the description, but that can be in a future PR

anchovie91471 · 2024-03-23T15:12:40Z

oh ok i see your response - i'd like to discuss this a little before merging

I think we should. What I did, eliminates the extra files generated by Mix, but adds a build step so we may want to discuss that in addition to whatever you'd like to discuss.

joshreisner · 2024-03-23T15:15:53Z

maybe i'm trying to add it to the wrong place, but i don't see width options on the block

nor on the columns parent

- Use tabs insotead of spaces in block.json for consistency

anchovie91471 · 2024-03-23T15:19:31Z

What theme are you using? 2024?

I think themes have to declare support for those options. It may be that we can declare that support in TSML. I can check.

anchovie91471 · 2024-03-23T15:34:27Z

I didn't realize I should have added support for alignWide in the block.json. Hopefully the latest commit fixes the issue with the alignment toolbar.

joshreisner · 2024-03-30T15:46:06Z

looks like dependabot's pr made a conflict in package-lock probably need to npm i to resolve it

i'm not seeing alignment options, but perhaps i'm doing it wrong? maybe we could meet at some point and you could show me how to do it?

also should i still be seeing "select a block type" on the right?

gkovats · 2024-08-11T15:15:12Z

FYI fixed the package-lock.json merge conflict.

kiyote33

Hi @anchovie91471, just starting a walk-thru today. Thought I'd give you some feedback before diving into the code. Install went as expected after downloading the PR branch. Initial configuration to drop the Meetings block on the home page of my test site was trivial. I dropped a container block on the page, set it to full width, and dropped the Meetings block into the container. The default setting for the Meetings block was left at Meetings UI. First look found everything as expected with TSML UI displaying to the full width of the container.
Moving to the other short codes, I tried them 1 at a time and found the following results:

Next Meetings. Clicked on link and got a 404 Page Not Found. Reset permalinks and still got the 404. On the Import page found the Data Source corrupted. Dropped the data source and recreated it. Problem solved with the 'Next Meetings' shortcode working as expected.
Types List. As expected, the list contained the types being used in my test data and clicking on the different types gave me a listing of meetings which had that type checked.
Regions List. Again as expected, the list contained the regions in my test data and clicking on a different region gave me a listing of meetings for that region.

Overall impression, no show stoppers. May need to do more investigation into why the corruption of the data source which seemed to occur between my initial load of the Meetings block and the change of settings to the 'Next Meetings' shortcode. I will do the investigation to find out if this is repeatable and needs to be addressed.

Before I dive into the code, could we get a merge of 3.15.1 into your code so I can test that everything works with our latest TSML? Much appreciate your work on this...

kiyote33

Not 100% sure the corrupted data source issue reported in an earlier comment is a bug related to this code, but it is repeatable. Here's the steps I took to repeat after 1st verifying I had a pristine environment with 36 test records:

Deactivated and removed the TSML plugin from the Installed Plugins folder.
After confirmation that the TSML plugin was removed, reinstalled and activated the plugin from the zip file in my Downloads folder.
Checked the Imports page for the Data Source status which showed 36 records available from the test data source JSON feed. Verified that the Meeting List showed the 36 records.
Switched the Meetings block from the default Meetings UI to the Next Meetings setting.
Returned to my home page listing which had the next 5 meetings available listed.
Clicked on the first in the listing and promptly got the 404 again.
Verified that there are no meeting or regions available in the Meetings editor.
Seems obvious that the meetings and regions are being blown away on deactivation or removal of the TSML plugin, but that the cache file remains, as well as the Data Source settings in the Options table. This is probably not related to this PR, but I think it does need to be resolved.

anchovie91471 · 2024-09-06T21:14:27Z

Wow! Thanks for the thorough review @kiyote33 and thanks @gkovats for stepping in on the merge conflict. I completely missed that.

Yep, I'll get the PR up to date with the latest TSML so we can test against that.

One thing I recall @joshreisner mentioned to me when we discussed this a while back, was splitting the the block into 4 separate embeddable blocks, instead of just one with the dropdown. I can certainly do that if the consensus is that would be more user friendly.

kiyote33

I like Josh's suggestion to have a separate block for each shortcode. I agree it would be more user friendly. Can we get a block for TSML too? Or do we need a shortcode for it first?

anchovie91471 · 2024-09-06T21:25:46Z

I like Josh's suggestion to have a separate block for each shortcode. I agree it would be more user friendly. Can we get a block for TSML too? Or do we need a shortcode for it first?

Do you mean the actual meeting list? (TSMI UI or Legacy). If so, there should be a choice in the dropdown for Meetings UI, which will render whichever is chosen in the settings for TSML.

kiyote33

Yep. Currently we only get TSML UI. It doesn't reference the TSML display setting at all. So there's no way to get the Legacy UI display if it's set to TSML UI.

joshreisner · 2024-09-06T21:45:46Z

since we have a goal of deprecating legacy, my vote would be to have the block be TSML UI only

…lock-for-wp-block-themes # Conflicts: # package-lock.json

anchovie91471 · 2024-09-06T23:15:19Z

OK. I've merge latest main into the branch @kiyote33

kiyote33

Works well in both classic and block themes.

package.json: - Added overrides in package.json for a few packages that threw audit warnings. - Added some build scripts - Added necessary scripts to build block

Setup styling components for all available css variables

joshreisner

awesome! thanks!

anchovie91471 added 2 commits March 8, 2024 22:20

Initial commit: Issue #1337 Add a Meetings block (for WP block themes)

98a583c

Remove debugging call from render.php

5ea3ce6

anchovie91471 linked an issue Mar 9, 2024 that may be closed by this pull request

Add a Meetings block (for WP block themes) #1337

Closed

anchovie91471 requested a review from joshreisner March 9, 2024 14:39

joshreisner reviewed Mar 23, 2024

View reviewed changes

Comment thread assets/build/blocks/block.json Outdated

joshreisner reviewed Mar 23, 2024

View reviewed changes

Comment thread assets/src/blocks/edit.js Outdated

joshreisner approved these changes Mar 23, 2024

View reviewed changes

joshreisner requested changes Mar 23, 2024

View reviewed changes

- Set .gitignore and webpack.mix.js back to original

60b5e96

- Use tabs insotead of spaces in block.json for consistency

anchovie91471 added 2 commits March 23, 2024 10:28

Add support for alignWide at block level

3ca9d85

Add support for alignWide at block level

8e1f39a

Merge branch 'main' into 1337-add-a-meetings-block-for-wp-block-themes

c84b345

kiyote33 self-requested a review September 6, 2024 12:41

kiyote33 reviewed Sep 6, 2024

View reviewed changes

kiyote33 requested changes Sep 6, 2024

View reviewed changes

kiyote33 reviewed Sep 6, 2024

View reviewed changes

anchovie91471 added 2 commits September 6, 2024 17:35

Merge remote-tracking branch 'origin/main' into 1337-add-a-meetings-b…

b978ba5

…lock-for-wp-block-themes # Conflicts: # package-lock.json

Adding updated package-lock.json and package-lock

b3e4889

kiyote33 approved these changes Sep 7, 2024

View reviewed changes

anchovie91471 added 2 commits November 16, 2024 11:27

Bring this branch up to date with current main branch (merge).

dab1552

package.json: - Added overrides in package.json for a few packages that threw audit warnings. - Added some build scripts - Added necessary scripts to build block

Remove all blocks except Meetings (tsml ui)

50bac95

Setup styling components for all available css variables

joshreisner approved these changes Dec 31, 2024

View reviewed changes

joshreisner merged commit 26743d9 into main Dec 31, 2024

Conversation

anchovie91471 commented Mar 9, 2024

Uh oh!

Uh oh!

Uh oh!

joshreisner left a comment

Choose a reason for hiding this comment

Uh oh!

joshreisner left a comment

Choose a reason for hiding this comment

Uh oh!

anchovie91471 commented Mar 23, 2024

Uh oh!

anchovie91471 commented Mar 23, 2024

Uh oh!

joshreisner commented Mar 23, 2024

Uh oh!

anchovie91471 commented Mar 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anchovie91471 commented Mar 23, 2024

Uh oh!

joshreisner commented Mar 30, 2024

Uh oh!

gkovats commented Aug 11, 2024

Uh oh!

kiyote33 left a comment

Choose a reason for hiding this comment

Uh oh!

kiyote33 left a comment

Choose a reason for hiding this comment

Uh oh!

anchovie91471 commented Sep 6, 2024

Uh oh!

kiyote33 left a comment

Choose a reason for hiding this comment

Uh oh!

anchovie91471 commented Sep 6, 2024

Uh oh!

kiyote33 left a comment

Choose a reason for hiding this comment

Uh oh!

joshreisner commented Sep 6, 2024

Uh oh!

anchovie91471 commented Sep 6, 2024

Uh oh!

kiyote33 left a comment

Choose a reason for hiding this comment

Uh oh!

joshreisner left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anchovie91471 commented Mar 23, 2024 •

edited

Loading