Fix publish flag handling: --snapshot rejected and --no-git-tag ignored for private packages by mixelburg · Pull Request #1941 · changesets/changesets

mixelburg · 2026-04-23T22:06:13Z

Summary

Two related fixes for the changeset publish command, both stemming from CLI flag handling issues.

1. `--snapshot` flag incorrectly rejected by `changeset publish` (#1939)

Regression from #1889. The unknown-flag validation added in 2.31.0 rejects --snapshot when passed to changeset publish, even though it was silently accepted in 2.30.0.

The flag is a no-op for publish, but users commonly pass shared flags when chaining commands:

changeset version --snapshot && changeset publish --snapshot

Fix: Destructure snapshot from flags in the publish case so it's not passed to validateCommandFlags as an unknown flag.

2. `--no-git-tag` still creates git tags for private packages (#1938)

When privatePackages.tag: true, changeset publish --no-git-tag still creates git tags for untagged private packages because the gitTag guard only wraps the public package tagging path, not the private one.

if (gitTag) {
  await tagPublish(tool, successfulNpmPublishes, cwd);   // public: guarded ✓
}
// ...
await tagPublish(tool, untaggedPrivatePackageReleases, cwd);  // private: NOT guarded ✗

Fix: Wrap the private package tagPublish call in the same if (gitTag) guard.

Changes

packages/cli/src/run.ts: Add snapshot to the publish case destructuring
packages/cli/src/commands/publish/index.ts: Guard private package tagging with if (gitTag)
Changesets for both fixes

Tests

All existing tests pass (157 passed, 1 skipped).

By semver convention, 0.x packages are allowed to contain breaking changes in minor versions. When a peer dependency change triggers a major bump for a 0.x dependent, bump minor instead to avoid prematurely jumping to 1.0.0. Fixes changesets#1887

…ed for private packages Two fixes for the publish command: 1. Accept --snapshot flag in publish without error (regression from changesets#1889). The flag is a no-op for publish but users commonly pass it when piping `changeset version --snapshot && changeset publish` with shared args. 2. Respect --no-git-tag for private packages when privatePackages.tag is enabled. The gitTag guard was only applied to public package tagging but not to the private package tagging path. Fixes changesets#1939 Fixes changesets#1938

changeset-bot · 2026-04-23T22:06:18Z

🦋 Changeset detected

Latest commit: 6871119

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@changesets/cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2026-04-23T22:07:09Z

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.78%. Comparing base (5c4731f) to head (6871119).
⚠️ Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/cli/src/commands/publish/index.ts	0.00%	2 Missing ⚠️
packages/cli/src/run.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
+ Coverage   83.23%   83.78%   +0.54%     
==========================================
  Files          56       56              
  Lines        2434     2467      +33     
  Branches      734      749      +15     
==========================================
+ Hits         2026     2067      +41     
+ Misses        402      394       -8     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Andarist · 2026-04-30T09:23:52Z

+              // For 0.x versions, peer dependency major bump should be minor
+              // since semver allows breaking changes in minor versions for 0.x
+              if (dependentPackage.packageJson.version.startsWith("0.")) {
+                type = "minor";
+              } else {
+                type = "major";
+              }


This is unrelated change, please revert it

Andarist · 2026-04-30T09:25:30Z

      }
      case "publish": {
-        const { otp, tag, gitTag, ...rest }: CliOptions = flags;
+        const { otp, tag, gitTag, snapshot, ...rest }: CliOptions = flags;


I don't think we want to fix this, the usage was incorrect and accidentally accepted. So far we only have a single user report about this. So I'd revert this from here.

Andarist · 2026-04-30T09:27:38Z

+    if (gitTag) {
+      await tagPublish(tool, untaggedPrivatePackageReleases, cwd);
+    }


I'm double-checking - this isn't related to a recent regression, right?

beeequeue · 2026-04-30T09:48:53Z

this seems to be a bot opening PRs randomly without oversight

storybookjs/storybook#34453 (comment)

Filipoliko · 2026-05-05T11:15:50Z

Note that rejecting the --snapshot flag on changeset publish command was a breaking change released as a minor update. Although it was a noop until now, it was a documented usage of snapshot feature until 27.5.2025 #1578

We ran into the same problem in our CIs, which broke after a package-lock.json update. Fix is quite simple (removing the --snapshot parameter from publish command), so we patched everything up now and moved on.

mixelburg added 2 commits April 18, 2026 22:11

Andarist reviewed Apr 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix publish flag handling: --snapshot rejected and --no-git-tag ignored for private packages#1941

Fix publish flag handling: --snapshot rejected and --no-git-tag ignored for private packages#1941
mixelburg wants to merge 2 commits into
changesets:mainfrom
mixelburg:fix/publish-snapshot-and-private-git-tag

mixelburg commented Apr 23, 2026

Uh oh!

changeset-bot Bot commented Apr 23, 2026

Uh oh!

codecov Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

Andarist Apr 30, 2026

Uh oh!

Andarist Apr 30, 2026

Uh oh!

Andarist Apr 30, 2026

Uh oh!

beeequeue commented Apr 30, 2026 •

edited

Loading

Uh oh!

Filipoliko commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mixelburg commented Apr 23, 2026

Summary

1. --snapshot flag incorrectly rejected by changeset publish (#1939)

2. --no-git-tag still creates git tags for private packages (#1938)

Changes

Tests

Uh oh!

changeset-bot Bot commented Apr 23, 2026

🦋 Changeset detected

Uh oh!

codecov Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Andarist Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Andarist Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Andarist Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

beeequeue commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Filipoliko commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

1. `--snapshot` flag incorrectly rejected by `changeset publish` (#1939)

2. `--no-git-tag` still creates git tags for private packages (#1938)

codecov Bot commented Apr 23, 2026 •

edited

Loading

beeequeue commented Apr 30, 2026 •

edited

Loading