fix(@changesets/read): ignore uppercase .md files in .changeset dir#1912
Open
mixelburg wants to merge 2 commits into
Open
fix(@changesets/read): ignore uppercase .md files in .changeset dir#1912mixelburg wants to merge 2 commits into
mixelburg wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: f22b1eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1912 +/- ##
==========================================
- Coverage 83.23% 83.22% -0.02%
==========================================
Files 56 56
Lines 2434 2432 -2
Branches 734 731 -3
==========================================
- Hits 2026 2024 -2
Misses 402 402
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I dont think its worth generalizing the rule right now. I’d just prefer maintaining an explicit allowlist - i dont expect it would really have that many entries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1906
Currently any
.mdfile in.changeset/that isn'tREADME.mdgets parsed as a changeset. This causes a cryptic parse error when you put docs likeAGENTS.mdorCLAUDE.mdin there:The fix extends the existing
README.mdexclusion to cover all uppercase-starting filenames. The convention is already established (README.md) and natural — changeset IDs are always lowercase adjective-noun pairs.Changed
!/^README\.md$/i.test(file)to!/^[A-Z]/.test(file), soAGENTS.md,CLAUDE.md,CONTRIBUTING.md, etc. are all silently skipped.