Fix external dependency build in CMake#311
Open
kotaweav wants to merge 1 commit into
Open
Conversation
This fix allows graaf to be used as an external dependency using CMake's `FetchContent_Declare`. With `CMAKE_SOURCE_DIR`, CMake will look for `packaging/graaf.pc` in the project using Graaf, rather than Graaf itself. `PROJECT_SOURCE_DIR` is used over `CMAKE_CURRENT_SOURCE_DIR` to maintain consistency within the `CMakeLists.txt`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 59 59
Lines 2621 2621
Branches 136 136
=======================================
Hits 2610 2610
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Marking this PR as stale. It will not be automatically closed. Even though the maintainers of Graaf may not always have time to take a look in a timely fashion, your contributions are much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in 2a4715f
This fix allows Graaf to be used as an external dependency using CMake's
FetchContent_Declare. WithCMAKE_SOURCE_DIR, CMake will look forpackaging/graaf.pcin the project using Graaf, rather than Graaf itself.PROJECT_SOURCE_DIRis used overCMAKE_CURRENT_SOURCE_DIRto maintain consistency within theCMakeLists.txt.