Fix generation of units parser/lexer tables.#9662
Merged
Merged
Conversation
mhvk
added
units
Bug
Affects-dev
Contributor
Author
|
cc @bsipocz since she may want to merge this quickly to help get 4.0 out. |
Member
|
short note: I'll be able to test this only tomorrow. |
olebole
approved these changes
Nov 25, 2019
Member
olebole
left a comment
olebole
left a comment
There was a problem hiding this comment.
Yes that works for me. Thank you!
bsipocz
approved these changes
Nov 25, 2019
Member
|
Thank you @mhvk! |
bsipocz
added a commit
that referenced
this pull request
Dec 1, 2019
Fix generation of units parser/lexer tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow our testing missed that that the addition of strings in a docstring doesn't always work properly (actually, don't know why it seemed to work at all, but it
did(EDIT) seems to have - at least, correct tables were generated at some point, and those were propagated...).Anyway, with this change, the lextab/parsetab get properly generated again. I'll see if I can also device a test in our travis setup that captures this, but since that may be tricky, for now just the fix.
fixes #9659