Update modeling tests to use match in pytest.raises#13919
Merged
WilliamJamieson merged 2 commits intoOct 27, 2022
Conversation
efc6393 to
9a011c1
Compare
pllim
reviewed
Oct 27, 2022
Member
pllim
left a comment
There was a problem hiding this comment.
+693 −628 😱
Just a couple of minor comments. I think if CI passes, your changes should be ok...
perrygreenfield
approved these changes
Oct 27, 2022
Member
perrygreenfield
left a comment
There was a problem hiding this comment.
If the tests pass, that is generally good enough for me.
9a011c1 to
ab3ef5e
Compare
ab3ef5e to
b70ace6
Compare
Member
|
We just fixed the dev failure, so if you rebase again, you should get all green. FYI. |
95d4e8c to
6ac32ef
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
modelingto usematchinpytest.raises. This was inspired by #13905 doing the same fornddata.In addition it added message matching for error testing which where missing previously.
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel. Codestyle issues can be fixed by the bot.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.