Skip to content

Update modeling tests to use match in pytest.raises#13919

Merged
WilliamJamieson merged 2 commits into
astropy:mainfrom
WilliamJamieson:testing/modeling_raises
Oct 27, 2022
Merged

Update modeling tests to use match in pytest.raises#13919
WilliamJamieson merged 2 commits into
astropy:mainfrom
WilliamJamieson:testing/modeling_raises

Conversation

@WilliamJamieson
Copy link
Copy Markdown
Contributor

@WilliamJamieson WilliamJamieson commented Oct 27, 2022

Description

Updates modeling to use match in pytest.raises. This was inspired by #13905 doing the same for nddata.

In addition it added message matching for error testing which where missing previously.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+693 −628 😱

Just a couple of minor comments. I think if CI passes, your changes should be ok...

Comment thread astropy/modeling/tests/test_bounding_box.py Outdated
Comment thread astropy/modeling/tests/test_bounding_box.py Outdated
Copy link
Copy Markdown
Member

@perrygreenfield perrygreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests pass, that is generally good enough for me.

@pllim
Copy link
Copy Markdown
Member

pllim commented Oct 27, 2022

We just fixed the dev failure, so if you rebase again, you should get all green. FYI.

@WilliamJamieson WilliamJamieson force-pushed the testing/modeling_raises branch from 95d4e8c to 6ac32ef Compare October 27, 2022 18:53
@WilliamJamieson WilliamJamieson merged commit 4537842 into astropy:main Oct 27, 2022
@WilliamJamieson WilliamJamieson deleted the testing/modeling_raises branch October 27, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants