Skip to content

Update nddata tests to use newer pytest syntax#13905

Merged
pllim merged 1 commit into
astropy:mainfrom
mwcraig:use-match-ndddata-tests
Oct 26, 2022
Merged

Update nddata tests to use newer pytest syntax#13905
pllim merged 1 commit into
astropy:mainfrom
mwcraig:use-match-ndddata-tests

Conversation

@mwcraig
Copy link
Copy Markdown
Member

@mwcraig mwcraig commented Oct 26, 2022

Description

Updates the nddata tests to use the match=... argument in tests for exception messages.

This includes a fix for a broken test that was included in the (otherwise unrelated) PR #13743

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

Copy link
Copy Markdown
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncontroversial enough as long as CI passes. Thanks!

@pllim pllim merged commit 3aabda9 into astropy:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants