update

apache · SteveYurongSu · May 16, 2025 · Mar 5, 2025 · Mar 20, 2025 · Mar 23, 2025
commit caa3907a0cf8f68ad80b403f2d63352aa3d486f0
diff --git a/.../main/java/org/apache/iotdb/confignode/procedure/impl/pipe/util/ExternalLoadBalancer.java b/.../main/java/org/apache/iotdb/confignode/procedure/impl/pipe/util/ExternalLoadBalancer.java
@@ -60,18 +60,25 @@ public ExternalLoadBalancer(final String balanceStrategy) {
    * @return a mapping from task index to leader node id
    */
   public Map<Integer, Integer> balance(
-      int parallelCount, PipeStaticMeta pipeStaticMeta, ConfigManager configManager) {
+      final int parallelCount,
+      final PipeStaticMeta pipeStaticMeta,
+      final ConfigManager configManager) {
     return strategy.balance(parallelCount, pipeStaticMeta, configManager);
   }
 
   public interface BalanceStrategy {
     Map<Integer, Integer> balance(
-        int parallelCount, PipeStaticMeta pipeStaticMeta, ConfigManager configManager);
+        final int parallelCount,
+        final PipeStaticMeta pipeStaticMeta,
+        final ConfigManager configManager);
   }
 
   public static class ProportionalBalanceStrategy implements BalanceStrategy {
+    @Override
     public Map<Integer, Integer> balance(
-        int parallelCount, PipeStaticMeta pipeStaticMeta, ConfigManager configManager) {
+        final int parallelCount,
+        final PipeStaticMeta pipeStaticMeta,
+        final ConfigManager configManager) {
       final Map<TConsensusGroupId, Integer> regionLeaderMap =
           configManager.getLoadManager().getRegionLeaderMap();
       final Map<Integer, Integer> parallelAssignment = new HashMap<>();
@@ -135,7 +142,7 @@ public Map<Integer, Integer> balance(
       final Map<Integer, Double> leaderRegionId2ExactShareMap = new HashMap<>();
       final Map<Integer, Integer> leaderRegionId2AssignedCountMap = new HashMap<>();
       for (Map.Entry<Integer, Integer> entry : leaderRegionId2DataRegionCountMap.entrySet()) {
-        double share = (parallelCount * entry.getValue()) / (double) totalRegions;
+        final double share = (parallelCount * entry.getValue()) / (double) totalRegions;
         leaderRegionId2ExactShareMap.put(entry.getKey(), share);
         leaderRegionId2AssignedCountMap.put(entry.getKey(), (int) Math.floor(share));
       }
@@ -149,7 +156,7 @@ public Map<Integer, Integer> balance(
           leaderRegionId2ExactShareMap.keySet().stream()
               .sorted(
                   (l1, l2) -> {
-                    double diff =
+                    final double diff =
                         (leaderRegionId2ExactShareMap.get(l2)
                                 - Math.floor(leaderRegionId2ExactShareMap.get(l2)))
                             - (leaderRegionId2ExactShareMap.get(l1)
@@ -163,11 +170,11 @@ public Map<Integer, Integer> balance(
             leaderId, leaderRegionId2AssignedCountMap.get(leaderId) + 1);
       }
 
-      List<Integer> stableLeaders = new ArrayList<>(leaderRegionId2AssignedCountMap.keySet());
+      final List<Integer> stableLeaders = new ArrayList<>(leaderRegionId2AssignedCountMap.keySet());
       Collections.sort(stableLeaders);
       int taskIndex = 1;
       for (final Integer leader : stableLeaders) {
-        int count = leaderRegionId2AssignedCountMap.get(leader);
+        final int count = leaderRegionId2AssignedCountMap.get(leader);
         for (int i = 0; i < count; i++) {
           parallelAssignment.put(-taskIndex, leader);
           taskIndex++;

diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/mqtt/MQTTExtractor.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/mqtt/MQTTExtractor.java
@@ -71,7 +71,7 @@ public class MQTTExtractor implements PipeExtractor {
   protected final AtomicBoolean isClosed = new AtomicBoolean(false);
 
   @Override
-  public void validate(PipeParameterValidator validator) throws Exception {
+  public void validate(final PipeParameterValidator validator) throws Exception {
     if (!validator
         .getParameters()
         .getBooleanOrDefault(
@@ -84,7 +84,8 @@ public void validate(PipeParameterValidator validator) throws Exception {
   }
 
   @Override
-  public void customize(PipeParameters parameters, PipeExtractorRuntimeConfiguration configuration)
+  public void customize(
+      final PipeParameters parameters, final PipeExtractorRuntimeConfiguration configuration)
       throws Exception {
     final PipeTaskExtractorRuntimeEnvironment environment =
         (PipeTaskExtractorRuntimeEnvironment) configuration.getRuntimeEnvironment();
@@ -137,8 +138,8 @@ public void close() throws Exception {
     }
   }
 
-  private IConfig createBrokerConfig(PipeParameters pipeParameters) {
-    Properties properties = new Properties();
+  private IConfig createBrokerConfig(final PipeParameters pipeParameters) {
+    final Properties properties = new Properties();
     properties.setProperty(
         BrokerConstants.HOST_PROPERTY_NAME,
         pipeParameters.getStringOrDefault(

diff --git a/...re/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/mqtt/MQTTPublishHandler.java b/...re/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/mqtt/MQTTPublishHandler.java
@@ -84,9 +84,9 @@ public class MQTTPublishHandler extends AbstractInterceptHandler {
   private final PipeTaskMeta pipeTaskMeta;
 
   public MQTTPublishHandler(
-      PipeParameters pipeParameters,
-      PipeTaskExtractorRuntimeEnvironment environment,
-      UnboundedBlockingPendingQueue<EnrichedEvent> pendingQueue) {
+      final PipeParameters pipeParameters,
+      final PipeTaskExtractorRuntimeEnvironment environment,
+      final UnboundedBlockingPendingQueue<EnrichedEvent> pendingQueue) {
     this.payloadFormat =
         PayloadFormatManager.getPayloadFormat(
             pipeParameters.getStringOrDefault(
@@ -107,7 +107,7 @@ public String getID() {
   @Override
   public void onConnect(InterceptConnectMessage msg) {
     if (!clientIdToSessionMap.containsKey(msg.getClientID())) {
-      MqttClientSession session = new MqttClientSession(msg.getClientID());
+      final MqttClientSession session = new MqttClientSession(msg.getClientID());
       sessionManager.login(
           session,
           msg.getUsername(),
@@ -123,7 +123,7 @@ public void onConnect(InterceptConnectMessage msg) {
 
   @Override
   public void onDisconnect(InterceptDisconnectMessage msg) {
-    MqttClientSession session = clientIdToSessionMap.remove(msg.getClientID());
+    final MqttClientSession session = clientIdToSessionMap.remove(msg.getClientID());
     if (null != session) {
       sessionManager.removeCurrSession();
       sessionManager.closeSession(session, Coordinator.getInstance()::cleanupQueryExecution);
@@ -133,15 +133,15 @@ public void onDisconnect(InterceptDisconnectMessage msg) {
   @Override
   public void onPublish(InterceptPublishMessage msg) {
     try {
-      String clientId = msg.getClientID();
+      final String clientId = msg.getClientID();
       if (!clientIdToSessionMap.containsKey(clientId)) {
         return;
       }
-      MqttClientSession session = clientIdToSessionMap.get(msg.getClientID());
-      ByteBuf payload = msg.getPayload();
-      String topic = msg.getTopicName();
-      String username = msg.getUsername();
-      MqttQoS qos = msg.getQos();
+      final MqttClientSession session = clientIdToSessionMap.get(msg.getClientID());
+      final ByteBuf payload = msg.getPayload();
+      final String topic = msg.getTopicName();
+      final String username = msg.getUsername();
+      final MqttQoS qos = msg.getQos();
 
       LOGGER.debug(
           "Receive publish message. clientId: {}, username: {}, qos: {}, topic: {}, payload: {}",
@@ -151,7 +151,7 @@ public void onPublish(InterceptPublishMessage msg) {
           topic,
           payload);
 
-      List<Message> messages = payloadFormat.format(payload);
+      final List<Message> messages = payloadFormat.format(payload);
       if (messages == null) {
         return;
       }
@@ -161,9 +161,9 @@ public void onPublish(InterceptPublishMessage msg) {
           continue;
         }
         if (useTableInsert) {
-          TableMessage tableMessage = (TableMessage) message;
+          final TableMessage tableMessage = (TableMessage) message;
           // '/' previously defined as a database name
-          String database =
+          final String database =
               !msg.getTopicName().contains("/")
                   ? msg.getTopicName()
                   : msg.getTopicName().substring(0, msg.getTopicName().indexOf("/"));
@@ -182,12 +182,12 @@ public void onPublish(InterceptPublishMessage msg) {
   }
 
   /** Inserting table using tablet */
-  private void extractTable(TableMessage message, MqttClientSession session) {
+  private void extractTable(final TableMessage message, final MqttClientSession session) {
     try {
       TimestampPrecisionUtils.checkTimestampPrecision(message.getTimestamp());
       session.setDatabaseName(message.getDatabase().toLowerCase());
       session.setSqlDialect(IClientSession.SqlDialect.TABLE);
-      EnrichedEvent event = generateEvent(message);
+      final EnrichedEvent event = generateEvent(message);
       if (!event.increaseReferenceCount(MQTTPublishHandler.class.getName())) {
         LOGGER.warn("The reference count of the event {} cannot be increased, skipping it.", event);
       }
@@ -205,7 +205,7 @@ private void extractTable(TableMessage message, MqttClientSession session) {
     }
   }
 
-  private PipeRawTabletInsertionEvent generateEvent(TableMessage message) {
+  private PipeRawTabletInsertionEvent generateEvent(final TableMessage message) {
     final List<String> measurements =
         Stream.of(message.getFields(), message.getTagKeys(), message.getAttributeKeys())
             .flatMap(List::stream)
@@ -242,7 +242,7 @@ private PipeRawTabletInsertionEvent generateEvent(TableMessage message) {
       schemas[i] = new MeasurementSchema(measurements.get(i), dataTypes[i]);
     }
 
-    Tablet eventTablet =
+    final Tablet eventTablet =
         new Tablet(
             message.getTable(),
             Arrays.asList(schemas),
@@ -266,15 +266,15 @@ private PipeRawTabletInsertionEvent generateEvent(TableMessage message) {
         false);
   }
 
-  private void extractTree(TreeMessage message, MqttClientSession session) {
+  private void extractTree(final TreeMessage message, final MqttClientSession session) {
     TSStatus tsStatus = null;
     try {
       TimestampPrecisionUtils.checkTimestampPrecision(message.getTimestamp());
       tsStatus = checkAuthority(session);
       if (tsStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
         LOGGER.warn(tsStatus.message);
       } else {
-        EnrichedEvent event = generateEvent(message);
+        final EnrichedEvent event = generateEvent(message);
         if (!event.increaseReferenceCount(MQTTPublishHandler.class.getName())) {
           LOGGER.warn(
               "The reference count of the event {} cannot be increased, skipping it.", event);
@@ -291,7 +291,7 @@ private void extractTree(TreeMessage message, MqttClientSession session) {
     }
   }
 
-  private EnrichedEvent generateEvent(TreeMessage message) throws QueryProcessException {
+  private EnrichedEvent generateEvent(final TreeMessage message) throws QueryProcessException {
     final String deviceId = message.getDevice();
     final List<String> measurements = message.getMeasurements();
     final long[] timestamps = new long[] {message.getTimestamp()};
@@ -337,7 +337,7 @@ private EnrichedEvent generateEvent(TreeMessage message) throws QueryProcessExce
       }
     }
 
-    Tablet eventTablet =
+    final Tablet eventTablet =
         new Tablet(deviceId, Arrays.asList(schemas), timestamps, inferredValues, bitMaps, 1);
 
     return new PipeRawTabletInsertionEvent(
@@ -354,8 +354,8 @@ private EnrichedEvent generateEvent(TreeMessage message) throws QueryProcessExce
         false);
   }
 
-  private static TSStatus checkAuthority(MqttClientSession session) {
-    long startTime = System.nanoTime();
+  private static TSStatus checkAuthority(final MqttClientSession session) {
+    final long startTime = System.nanoTime();
     try {
       return AuthorityChecker.getTSStatus(
           AuthorityChecker.SUPER_USER.equals(session.getUsername()),

diff --git a/...java/org/apache/iotdb/commons/pipe/agent/plugin/builtin/extractor/mqtt/MQTTExtractor.java b/...java/org/apache/iotdb/commons/pipe/agent/plugin/builtin/extractor/mqtt/MQTTExtractor.java
@@ -20,11 +20,15 @@
 package org.apache.iotdb.commons.pipe.agent.plugin.builtin.extractor.mqtt;
 
 import org.apache.iotdb.pipe.api.PipeExtractor;
+import org.apache.iotdb.pipe.api.annotation.TableModel;
+import org.apache.iotdb.pipe.api.annotation.TreeModel;
 import org.apache.iotdb.pipe.api.customizer.configuration.PipeExtractorRuntimeConfiguration;
 import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameterValidator;
 import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameters;
 import org.apache.iotdb.pipe.api.event.Event;
 
+@TreeModel
+@TableModel
 public class MQTTExtractor implements PipeExtractor {
 
   private static final String PLACEHOLDER_ERROR_MSG =