Skip to content

Pipe: Fixed the tsFile parsing & write-back-sink auto create db bug #15240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveYurongSu merged 5 commits into from
Mar 31, 2025
Merged

Pipe: Fixed the tsFile parsing & write-back-sink auto create db bug #15240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d5605f
may complete
Caideyipi Mar 31, 2025
6c46ef6
Fix and rollback
Caideyipi Mar 31, 2025
e7f90c5
Update IoTDBPipePermissionIT.java
Caideyipi Mar 31, 2025
62feb4a
Update IoTDBPipePermissionIT.java
Caideyipi Mar 31, 2025
b4c68ab
Update IoTDBPipePermissionIT.java
Caideyipi Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix and rollback
  • Loading branch information
@Caideyipi
Caideyipi committed Mar 31, 2025
commit 6c46ef6553dac368535634547d3f6009d8f92e6b
17 changes: 6 additions & 11 deletions integration-test/src/test/java/org/apache/iotdb/pipe/it/single/IoTDBPipePermissionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,6 @@
public class IoTDBPipePermissionIT extends AbstractPipeSingleIT {
@Test
public void testSinkPermission() {
// Prepare partial data
TableModelUtils.createDataBaseAndTable(env, "test", "test1");
TableModelUtils.createDataBaseAndTable(env, "test1", "test1");
TableModelUtils.createDataBaseAndTable(env, "test", "test");
TableModelUtils.createDataBaseAndTable(env, "test1", "test");

if (!TableModelUtils.insertData("test1", "test1", 0, 50, env)) {
return;
}

if (!TestUtils.tryExecuteNonQueryWithRetry(env, "create user `thulab` 'passwd'")) {
return;
}
Expand Down Expand Up @@ -104,6 +94,11 @@ public void testSinkPermission() {
fail("Alter pipe shall not fail if user and password are specified");
}

TableModelUtils.createDataBaseAndTable(env, "test", "test1");
TableModelUtils.createDataBaseAndTable(env, "test1", "test1");
TableModelUtils.createDataBaseAndTable(env, "test", "test");
TableModelUtils.createDataBaseAndTable(env, "test1", "test");

// Write some data
if (!TableModelUtils.insertData("test1", "test", 0, 100, env)) {
return;
Expand All @@ -122,7 +117,7 @@ public void testSinkPermission() {
"test1", BaseEnv.TABLE_SQL_DIALECT, env, "grant INSERT on test.test1 to user thulab")) {
return;
}
if (!TableModelUtils.insertData("test1", "test1", 50, 100, env)) {
if (!TableModelUtils.insertData("test1", "test1", 0, 100, env)) {
return;
}
TableModelUtils.assertCountData("test", "test1", 100, env);
Expand Down
13 changes: 10 additions & 3 deletions ...c/main/java/org/apache/iotdb/db/pipe/connector/protocol/writeback/WriteBackConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,16 @@ private void autoCreateDatabaseIfNecessary(final String database) {
return;
}

Coordinator.getInstance()
.getAccessControl()
.checkCanCreateDatabase(session.getUsername(), database);
try {
Coordinator.getInstance()
.getAccessControl()
.checkCanCreateDatabase(session.getUsername(), database);
} catch (final AccessDeniedException e) {
// Auto create failed, we still check if there are existing databases
// If there are not, this will be removed by catching database not exists exception
ALREADY_CREATED_DATABASES.add(database);
return;
}
final TDatabaseSchema schema = new TDatabaseSchema(new TDatabaseSchema(database));
schema.setIsTableModel(true);

Expand Down