Skip to content

feat: add PaginationList for lazy page fetching in catalog list operations #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stark256-spec wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: add PaginationList for lazy page fetching in catalog list operations #3454

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
91f3640
feat: add PaginationList for lazy page fetching in catalog list opera…
stark256-spec Jun 3, 2026
5a01899
fix(pagination): resolve mypy and ruff lint errors
stark256-spec Jun 3, 2026
98d6900
fix(tests): resolve ruff lint errors and add len() performance tests
stark256-spec Jun 3, 2026
9fbcdd3
fix(pagination): add docstrings to __getitem__ overload stubs for pyd…
stark256-spec Jun 3, 2026
10c2ba0
fix(pagination): use noqa:D105 on overload stubs instead of docstrings
stark256-spec Jun 3, 2026
0b08854
fix(pagination): drop @overload stubs to resolve D105/D418 pydocstyle…
stark256-spec Jun 3, 2026
6a7b6d0
fix(pagination): add D105/D418 to pydocstyle ignore list; restore @ov…
stark256-spec Jun 3, 2026
d71317c
fix(tests): move PaginationList import to correct alphabetical positi…
stark256-spec Jun 4, 2026
1780ae6
fix(tests): account for RestCatalog config endpoint call in call_coun…
stark256-spec Jun 4, 2026
e2bb799
refactor(pagination): move PaginationList to typedef, add PageFetchRe…
stark256-spec Jun 6, 2026
392a8f5
fix: update PaginationList import in test_rest.py
stark256-spec Jun 6, 2026
7ab945a
fix(lint): add D105 back to pydocstyle ignore for @overload stubs
stark256-spec Jun 10, 2026
329b1bd
fix: resolve ruff import ordering and pagination cleanup bug
stark256-spec Jun 10, 2026
769728d
feat(pagination): add count, index, reversed, copy, and + to Paginati…
stark256-spec Jun 11, 2026
3883280
Address review nits: named FetchNextPage alias and HTTP call count as…
stark256-spec Jun 19, 2026
1c3abd9
Add __mul__ and __rmul__ overrides to PaginationList
stark256-spec Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(pagination): use noqa:D105 on overload stubs instead of docstrings 
D418 prohibits docstrings on @overload stubs; suppress D105 (missing
docstring in magic method) with inline noqa comments instead.
  • Loading branch information
@stark256-spec
stark256-spec committed Jun 3, 2026
commit 10c2ba02238d72d63c0f7659349053874bfccbd8
8 changes: 2 additions & 6 deletions pyiceberg/utils/pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,10 @@ def __ne__(self, other: object) -> bool:
# ------------------------------------------------------------------

@overload
def __getitem__(self, idx: SupportsIndex) -> T:
"""Return item at integer index, fetching pages as needed."""
...
def __getitem__(self, idx: SupportsIndex) -> T: ... # noqa: D105

@overload
def __getitem__(self, idx: slice) -> list[T]:
"""Return slice, fetching all remaining pages first."""
...
def __getitem__(self, idx: slice) -> list[T]: ... # noqa: D105

def __getitem__(self, idx: SupportsIndex | slice) -> T | list[T]:
"""Fetch pages as needed before returning the requested item(s)."""
Expand Down
Loading