[fix](be) Use VExpr for file scanner v2 ZoneMap pruning#65175
Draft
Gabriel39 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: File scanner v2 still carried ColumnPredicate metadata pruning through FileScanRequest for Parquet row-group dictionary and bloom filters after ZoneMap pruning had moved to VExpr. This kept two pruning APIs in the same scanner path and made statistics/profile accounting harder to keep consistent. This change adds VExpr dictionary and bloom-filter evaluation interfaces, wires comparison/IN/compound predicates through those interfaces, and makes the Parquet v2 row-group/page pruning path evaluate localized VExpr conjuncts for ZoneMap, dictionary, and bloom filters. FileScanRequest no longer carries ColumnPredicate filters, while the existing STATISTICS/DICTIONARY/BLOOM_FILTER prune reasons and profile counters remain. This also keeps the earlier cleanup that translates Chinese comments under be/src/core/data_type_serde to English.
### Release note
None
### Check List (For Author)
- Test: Manual test
- Ran build-support/clang-format.sh
- Ran git diff --check and git diff --cached --check
- Verified no FileScannerV2 ColumnPredicate request/pruning symbols remain with rg
- Attempted BE UT filter ParquetStatistics*:ParquetScan*:NewParquetReader*:TableReader*:ColumnMapper*; it did not compile/run because local thirdparty dependencies are missing: thirdparty/installed/bin/protoc and Snappy. Also build-support/check-format.sh could not run because it could not find clang-format, although build-support/clang-format.sh completed successfully.
- Behavior changed: No
- Does this need documentation: No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: File scanner v2 still used ColumnPredicate min/max and page-index statistics to prune Parquet row groups and pages. VExpr now owns ZoneMap evaluation, so the Parquet v2 pruning path builds ZoneMapEvalContext from row-group statistics and page indexes and evaluates localized VExpr conjuncts instead. ColumnPredicate pruning is kept only for dictionary and bloom filters. The existing row-group and page ZoneMap counters are preserved, page-index row-group pruning is exposed in profile counters, and VExpr ZoneMap evaluation counters are reported in the Parquet profile.
This also translates the remaining Chinese comments under
be/src/core/data_type_serdeto English for consistency.Release note
None
Check List (For Author)
build-support/clang-format.shgit diff --checkrgbe/src/core/data_type_serdewithrgParquetStatisticsPruningTest.*:ParquetScanTest.*:NewParquetReaderTest.*; it did not compile/run because local thirdparty dependencies are missing (thirdparty/installed/bin/protocand Snappy).