feat(sdk/aws/workflow): Add stepWithRollbackV2 to fix rollback registration and config#6904
Open
anatolzak wants to merge 2 commits into
Open
feat(sdk/aws/workflow): Add stepWithRollbackV2 to fix rollback registration and config#6904anatolzak wants to merge 2 commits into
anatolzak wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6902 and #6903.
Two problems with
stepWithRollbacktoday:To avoid a breaking change, this adds
stepWithRollbackV2that fixes both. we now register the undo before the step runs, passes the result to the undo asTOutput | undefined. this way undo reconciles against real state when the step failed, and takes a separateundoConfig.The old
stepWithRollbackis kept and marked@deprecated.The workflow test file was also broken before this. it stubbed an
aws.fetchexport that doesn't exist, so the whole file threw on import and none of the tests ran (these SDK tests aren't in CI, so I guess it went unnoticed). The first commit fixes that by mockingawsFetchviamock.moduleinstead, so the suite actually loads before the V2 work builds on it.